Bug 30193

Summary: Invalid refs removed in JSON::Validator 5.x
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: REST APIAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: RESOLVED DUPLICATE QA Contact:
Severity: major    
Priority: P5 - low CC: martin.renvoize, mtj, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 30194    
Attachments: Bug 30193: Remove use of allow_invalid_ref

Description Tomás Cohen Arazi (tcohen) 2022-02-28 11:00:03 UTC
Newer versions of JSON::Validator got the 'allow_invalid_refs' feature removed. We need to (finally) tweak our spec files to match the OpenAPI standard.
Comment 1 Tomás Cohen Arazi (tcohen) 2022-03-03 19:21:18 UTC
Created attachment 131347 [details] [review]
Bug 30193: Remove use of allow_invalid_ref

This patch removes the code that makes Koha allow an invalid spec It is
expected to break the API.

As an excercise, try saving the raw output from
http://localhost:8080/api/v1 into swagger.json along the swagger.yaml
file, and tweak V1.pm to point to the json version.

Notice the API works! The idea, is we adapt our API so it conforms to
the standard as much as possible, while keeping some modularity.
Comment 2 Tomás Cohen Arazi (tcohen) 2022-03-08 17:58:33 UTC
It is all or nothing it seems. Marking as duplicate of the invalid refs one.

*** This bug has been marked as a duplicate of bug 30194 ***