Summary: | "Item found" in accountlines untranslatable | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | I18N/L10N | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Caroline Cyr La Rose
2022-03-02 23:57:00 UTC
The problem is here: my $credit; if ( $credit_total > 0 ) { my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; $credit = $account->add_credit( { amount => $credit_total, description => 'Item found ' . $self->itemnumber, type => 'LOST_FOUND', interface => C4::Context->interface, library_id => $branchcode, item_id => $self->itemnumber, issue_id => $lost_charge->issue_id } ); Having the description option seems to be a bad idea in the first place when it's not used for adding variables like the title, due date etc. Always meant trouble for translations. I also agree about the itemnumber not being useful. We do have the link to the item displaying in the table, there is no need for it in the description. |