Summary: | Hide lost items not respected in OPAC results XSLT | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.05
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 24403 | ||
Attachments: |
Bug 30244: Include lost items in list of hidden items
Bug 30244: Include lost items in list of hidden items Bug 30244: Include lost items in list of hidden items |
Description
Nick Clemens (kidclamp)
2022-03-07 19:52:44 UTC
Created attachment 131588 [details] [review] Bug 30244: Include lost items in list of hidden items When building search results for XSLT we generate and pass a list of hidden itemnumbers. We do skip the lost items in our parsing, however, we neglect to add the itemnumber to the hidden list This patch simply adds the lost itemnumbers to the list There is more work to be done here to simpliofy this process, however, this patch resolves the issue and can be backported to stable branches To test: 1 - Set systempreference hidelostitems to "Don't show" 2 - Edit a record to set one item as lost and one as available 3 - Perform an OPAC search that returns the record above 4 - Note that the lost item shows in availability line 5 - Click on the record - note the lost item does not show on details 6 - Apply patch 7 - Reload search results 8 - Lost itme no longer displays Created attachment 131591 [details] [review] Bug 30244: Include lost items in list of hidden items When building search results for XSLT we generate and pass a list of hidden itemnumbers. We do skip the lost items in our parsing, however, we neglect to add the itemnumber to the hidden list This patch simply adds the lost itemnumbers to the list There is more work to be done here to simpliofy this process, however, this patch resolves the issue and can be backported to stable branches To test: 1 - Set systempreference hidelostitems to "Don't show" 2 - Edit a record to set one item as lost and one as available 3 - Perform an OPAC search that returns the record above 4 - Note that the lost item shows in availability line 5 - Click on the record - note the lost item does not show on details 6 - Apply patch 7 - Reload search results 8 - Lost itme no longer displays Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 132193 [details] [review] Bug 30244: Include lost items in list of hidden items When building search results for XSLT we generate and pass a list of hidden itemnumbers. We do skip the lost items in our parsing, however, we neglect to add the itemnumber to the hidden list This patch simply adds the lost itemnumbers to the list There is more work to be done here to simpliofy this process, however, this patch resolves the issue and can be backported to stable branches To test: 1 - Set systempreference hidelostitems to "Don't show" 2 - Edit a record to set one item as lost and one as available 3 - Perform an OPAC search that returns the record above 4 - Note that the lost item shows in availability line 5 - Click on the record - note the lost item does not show on details 6 - Apply patch 7 - Reload search results 8 - Lost itme no longer displays Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Confirmed this resolves the issue and agree we should tidy up a bit in a future bug but keep this as a simple backport. Passing QA Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.05 |