| Summary: | Script which checks index should also check if the zebraqueue has uncommitted records | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Architecture, internals, and plumbing | Assignee: | Aleisha Amohia <aleisha> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, martin.renvoize, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 30260: Add is_indexer_working check
Bug 30260: [GLOBAL REPO] Implement is_indexer_working check Bug 30260: Add is_indexer_working check |
||
|
Description
Aleisha Amohia
2022-03-10 02:11:29 UTC
Created attachment 131532 [details] [review] Bug 30260: Add is_indexer_working check Function checks if the zebraqueue has rows that are not 'done' Will depend on a change in checkindex.sh which implements the check: https://git.koha-community.org/Koha-community/global/src/branch/master/koha-zebra/checkindex.sh To test: 1. disable the indexer sudo koha-indexer --stop INSTANCENAME 2. catalogue 5 new records 3. confirm they don't show in any search results 4. in your terminal, go to the shell sudo koha-shell INSTANCENAME 5. run the new script. run with -v for verbose or --rows X to specify how many uncommitted records should be checked for. 5 is the default perl misc/maintenance/check_zebraqueue.pl 6. confirm the script returns that the indexer is not working. The function in koha-functions.sh is required for the pending change to checkindex.sh Sponsored-by: Catalyst IT Unfortunately I can't seem to push to the repo, can someone please help? I can attach the patch here but it won't apply to a koha clone. Am trying to push to this repo: https://git.koha-community.org/Koha-community/global/ Created attachment 131582 [details] [review] Bug 30260: [GLOBAL REPO] Implement is_indexer_working check Tomas or Martin, can you help with pushing to https://git.koha-community.org/Koha-community/global/? I had no idea that repo existed. How should I get that patch into the global repo? Created attachment 160395 [details] [review] Bug 30260: Add is_indexer_working check Function checks if the zebraqueue has rows that are not 'done' Will depend on a change in checkindex.sh which implements the check: https://git.koha-community.org/Koha-community/global/src/branch/master/koha-zebra/checkindex.sh To test: 1. disable the indexer sudo koha-indexer --stop INSTANCENAME 2. catalogue 5 new records 3. confirm they don't show in any search results 4. in your terminal, go to the shell sudo koha-shell INSTANCENAME 5. run the new script. run with -v for verbose or --rows X to specify how many uncommitted records should be checked for. 5 is the default perl misc/maintenance/check_zebraqueue.pl 6. confirm the script returns that the indexer is not working. The function in koha-functions.sh is required for the pending change to checkindex.sh Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Patch still applies and it worked for me: I had to add 6 new records for the default of 5 to work. Maybe check with Jonathan about the repo - probably something to do with access when we changed to Gitea. Maybe the repository should be added to gitlab.com/koha-community Comment on attachment 131582 [details] [review] Bug 30260: [GLOBAL REPO] Implement is_indexer_working check This patch has now been pushed to the global repo, so the other patch can be pushed to Koha. https://git.koha-community.org/Koha-community/global/commit/72308768457017c3ff48543c9a52295a064a7253 I don't think we need this fix anymore, with a combination of the following fixes instead: * Bug 36548 (the bug solved here was the believed cause for this fix) * https://git.koha-community.org/Koha-community/global/commit/704060f4ff5497b545b9d807e2ea57c5cc7a85b9 *** This bug has been marked as a duplicate of bug 36548 *** |