|
Description
Aleisha Amohia
2022-03-15 01:18:01 UTC
Created attachment 131763 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Patch no longer applies: git bz apply 30295 Bug 30295 - Send a notification when a recall is manually cancelled 131763 - Bug 30295: Send a notification when a recall is manually cancelled Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30295: Send a notification when a recall is manually cancelled error: sha1 information is lacking or useless (Koha/Recall.pm). error: could not build fake ancestor Patch failed at 0001 Bug 30295: Send a notification when a recall is manually cancelled Created attachment 140243 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Created attachment 140245 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology The patch no longer applies 8-(.. I'll try and test a bit quicker next time! Created attachment 147108 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology I could not get the cancel recall notification to show up at the notices tab. I tried different patrons and different book, also tried recalling both bib and item. I did see other recall related notices, but never a recall cancelled notice. Created attachment 148114 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Created attachment 149127 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Saw both the SMS and email notice. Confirmed that the recall cancelled notice is sent both when the recall is cancelled on the staff side and also when the recall is cancelled by the patron in the OPAC. Created attachment 150431 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Base patch set in FQA Created attachment 155347 [details] [review] Bug 30295: Use blessed patron to enqueue notice and QA fixes Base patch set has been unblocked. Most recent patch is a response to changes in C4::Message->enqueue, so please retest that the notice is generated and enqueued. Created attachment 155358 [details] [review] Bug 30295: Use blessed patron to enqueue notice and QA fixes Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Worked as described in test plan I think this needs to have the phone transport option as well. Created attachment 158699 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Created attachment 158700 [details] [review] Bug 30295: Use blessed patron to enqueue notice and QA fixes Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Created attachment 158701 [details] [review] Bug 30295: Add phone transport option Created attachment 159007 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 159008 [details] [review] Bug 30295: Use blessed patron to enqueue notice and QA fixes Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: David Nind <david@davidnind.com> Created attachment 159009 [details] [review] Bug 30295: Add phone transport option Signed-off-by: David Nind <david@davidnind.com> This needs to have support for the phone transport as well. Created attachment 172038 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 172039 [details] [review] Bug 30295: Use blessed patron to enqueue notice and QA fixes Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: David Nind <david@davidnind.com> Created attachment 172041 [details] [review] Bug 30295: Add phone transport option Signed-off-by: David Nind <david@davidnind.com> These patches all have a signoff. Should it still be "Needs signoff" The patches no longer apply 8-(... When that is fixed, I think the status can change to signed off. git bz apply 30295 Bug 30295 - Send a notification when a recall is manually cancelled 172038 - Bug 30295: Send a notification when a recall is manually cancelled 172039 - Bug 30295: Use blessed patron to enqueue notice and QA fixes 172041 - Bug 30295: Add phone transport option Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30295: Send a notification when a recall is manually cancelled Using index info to reconstruct a base tree... M installer/data/mysql/en/mandatory/sample_notices.yml M installer/data/mysql/mandatory/sample_notices_message_transports.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/mandatory/sample_notices_message_transports.sql Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/sample_notices.yml error: Failed to merge in the changes. Patch failed at 0001 Bug 30295: Send a notification when a recall is manually cancelled Created attachment 186346 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 186347 [details] [review] Bug 30295: Use blessed patron to enqueue notice and QA fixes Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: David Nind <david@davidnind.com> Created attachment 186348 [details] [review] Bug 30295: Add phone transport option Signed-off-by: David Nind <david@davidnind.com> (In reply to David Nind from comment #29) > The patches no longer apply 8-(... When that is fixed, I think the status > can change to signed off. > I think I let too much time before coming back to rebase unfortunately. This should get re-tested please! Created attachment 192078 [details] [review] Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 192079 [details] [review] Bug 30295: Use blessed patron to enqueue notice and QA fixes Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 192080 [details] [review] Bug 30295: Add phone transport option Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 192081 [details] [review] Bug 30295: (follow-up) Merge database updates into one file with success messages Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 192082 [details] [review] Bug 30295: (follow-up) Spelling: Update cancelled to canceled According to: https://wiki.koha-community.org/wiki/Terminology#C Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 192083 [details] [review] Bug 30295: (follow-up) Udpate message_attribute_id Since this patch was first written the message_attribute_id 14 was taken by "Patron_Expiry". So we need to move to 15. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 192084 [details] [review] Bug 30295: (follow-up) Display messaging preferences in right sequence This is due to the change from bug 29194 that added logical ordering to the messaging preferences. Without this patch the new notice showed last in list, now it shows between Recall_Requested and Recall_Waiting. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi Aleisha, full report below, but good call with the re-testing! Fixed in follow-up. Problem was caused by bug 29194. (In reply to Aleisha Amohia from comment #33) > (In reply to David Nind from comment #29) > > The patches no longer apply 8-(... When that is fixed, I think the status > > can change to signed off. > > > I think I let too much time before coming back to rebase unfortunately. This > should get re-tested please! I found some issues that were mostly caused by changes since this was written. Would you mind reviewing the follow-ups and maybe signing them off? 1) QA checks - PASS! (fails with follow-up for the merging of the database update files, but I think this is OK here) 2) Code review a) Atomic updates could be merged into one file and are missing "success" messages. I'll provide a follow-up patch for this. b) Cancelled should be canceled. I stumbled over this as it was just a topic in the last development meeting. As we have in our coding guidelines to use AE, it should read canceled. https://wiki.koha-community.org/wiki/Terminology#C Example from patches: Recall has been cancelled We regret to inform you that the item you have recalled cannot be provided. Your recall was cancelled. Provided a second follow-up patch for this. 3) Testing a) Notice was not showing up in messaging preferences Fixed in follow-up. Problem was caused by message_transport_id mismatch (14 -> 15). b) Notice showed at the bottom of the list instead of with other recall notices > b) Notice showed at the bottom of the list instead of with other recall notices
Also fixed in last follow-up.
|