Summary: | Switch to Bootstrap tabs on the page for adding orders from MARC file | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | lucas, severine.queune, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30388 | ||
Bug Blocks: | |||
Attachments: |
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file |
Description
Owen Leonard
2022-03-28 19:13:20 UTC
Created attachment 132359 [details] [review] Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Created attachment 132821 [details] [review] Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Really nice Owen ! The alignment of the first tab is really better with the patch. I am afraid this is not quite ready for QA yet with the 2 dependent bugs not yet signed off. Moving to BLOCKED, back to QA queue soon. Created attachment 138133 [details] [review] Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Created attachment 138235 [details] [review] Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Missing 22.05.x dependencies, no backport |