Summary: | Bad JavaScript in IntranetUserJS can break the staff interface | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Staff interface | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, marie.hedbom, mrfawn |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Magnus Enger
2022-03-29 06:22:01 UTC
Hi Magnus, The intranet JS logic is injected into all Staff intranet pages on page load. This means that any JS added to the Intranet JS text area can possibly disrupt existing Koha JS and related core functionality. From my experience, using Intranet JS to inject some hot fixed for Koha Intranet staff UI can be useful if used sparingly. I generally run regression tests for my JS added source via a local vanilla test version of Koha, to test for any potential functionality friction, before apply to live/PROD. A possible long term fix for this potentially disruptive experience, could be to add micro regression tests to run on save of Intranet JS data input field. This would offer the very core testing for the possible logic blocks to things like JQUERY, which is used to power many of the koha UI front end behaviors. IMHO. Thoughts? Adam. |