Bug 30420

Summary:	Rename Koha::Patron->get_overdues with ->overdues
Product:	Koha	Reporter:	Martin Renvoize (ashimema) <martin.renvoize>
Component:	Architecture, internals, and plumbing	Assignee:	Jonathan Druart <jonathan.druart>
Status:	CLOSED FIXED	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	enhancement
Priority:	P5 - low	CC:	lucas, tomascohen
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:	Martin Renvoize	Documentation submission:
Text to go in the release notes:	This enhancement makes the method naming more consistent.	Version(s) released in:	22.11.00
Circulation function:
Bug Depends on:	30063
Bug Blocks:
Attachments:	Bug 30420: Rename Koha::Patron->get_overdues with ->overdues Bug 30420: Rename Koha::Patron->get_overdues with ->overdues

Description Martin Renvoize (ashimema) 2022-03-31 14:13:19 UTC

We should really replace the get_ accessor with the overdues accessor rather than just providing an alias.

We could also put the query at the dbic schema class level as a fully-fledged relationship and get some query construction benefits.

Comment 1 Jonathan Druart 2022-04-27 11:33:53 UTC

Created attachment 134058 [details] [review]
Bug 30420: Rename Koha::Patron->get_overdues with ->overdues

Comment 2 Martin Renvoize (ashimema) 2022-04-27 15:24:22 UTC

Created attachment 134079 [details] [review]
Bug 30420: Rename Koha::Patron->get_overdues with ->overdues

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 3 Martin Renvoize (ashimema) 2022-04-27 15:24:53 UTC

Thanks for the quick move here.. straight QAing.. no regressions, all cases caught..

Passing QA

Comment 4 Tomás Cohen Arazi (tcohen) 2022-06-14 11:51:32 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 5 Lucas Gass (lukeg) 2022-07-13 19:57:30 UTC

Enhancement will not be backported to 22.05.x series