Bug 30424

Summary: Reindent advanced search template in the staff interface
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: kyle, severine.queune, testopia
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Bug Depends on:    
Bug Blocks: 30433    
Attachments: Bug 30424: Reindent advanced search template in the staff interface
Bug 30424: (follow-up) Markup comments
Bug 30424: Reindent advanced search template in the staff interface
Bug 30424: (follow-up) Markup comments
Bug 30424: Reindent advanced search template in the staff interface
Bug 30424: (follow-up) Markup comments

Description Owen Leonard 2022-03-31 18:23:32 UTC
I would like reformat the advanced search template so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2022-04-01 13:00:06 UTC
Created attachment 132865 [details] [review]
Bug 30424: Reindent advanced search template in the staff interface

This patch reindents the advanced search template. Some lines have been
split to make the markup more readable.

To test, apply the patch and test the advanced search page in the staff
interface. Everything should work as normal. Be sure to test both the
"More options" and "Fewer options" views.

When viewing the diff for this change, ignore whitespace. The only
visible changes should be split lines.
Comment 2 Owen Leonard 2022-04-01 13:00:10 UTC
Created attachment 132866 [details] [review]
Bug 30424: (follow-up) Markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 Séverine Queune 2022-04-04 13:39:10 UTC
Created attachment 132939 [details] [review]
Bug 30424: Reindent advanced search template in the staff interface

This patch reindents the advanced search template. Some lines have been
split to make the markup more readable.

To test, apply the patch and test the advanced search page in the staff
interface. Everything should work as normal. Be sure to test both the
"More options" and "Fewer options" views.

When viewing the diff for this change, ignore whitespace. The only
visible changes should be split lines.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 4 Séverine Queune 2022-04-04 13:39:14 UTC
Created attachment 132940 [details] [review]
Bug 30424: (follow-up) Markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 5 Séverine Queune 2022-04-04 13:45:39 UTC
Nice re-indentation Owen !
Everything seemed ok for me using the patch.
Comment 6 Katrin Fischer 2022-04-24 12:36:09 UTC
Created attachment 133715 [details] [review]
Bug 30424: Reindent advanced search template in the staff interface

This patch reindents the advanced search template. Some lines have been
split to make the markup more readable.

To test, apply the patch and test the advanced search page in the staff
interface. Everything should work as normal. Be sure to test both the
"More options" and "Fewer options" views.

When viewing the diff for this change, ignore whitespace. The only
visible changes should be split lines.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-04-24 12:36:13 UTC
Created attachment 133716 [details] [review]
Bug 30424: (follow-up) Markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Fridolin Somers 2022-05-02 21:24:33 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄