Summary: | get_items_that_can_fill needs to specify table for biblionumbers | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, gmcharlt, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.05
|
|
Circulation function: | |||
Attachments: |
Bug 30432: Unit test
Bug 30432: Specify 'me' for biblionumber when limiting items Bug 30432: Unit test Bug 30432: Specify 'me' for biblionumber when limiting items Bug 30432: Unit test Bug 30432: Specify 'me' for biblionumber when limiting items Bug 30432: Fix random failure Bug 30432: [21.05.x] Specify 'me' for biblionumber when limiting items |
Description
Nick Clemens (kidclamp)
2022-04-01 12:48:12 UTC
Created attachment 132862 [details] [review] Bug 30432: Unit test Created attachment 132863 [details] [review] Bug 30432: Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! Created attachment 132930 [details] [review] Bug 30432: Unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 132931 [details] [review] Bug 30432: Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tests are failing for me t/db_dependent/Koha/Holds.t .. 5/7 # Failed test 'Items 1, 2, and 5 are available for filling the holds' # at t/db_dependent/Koha/Holds.t line 516. # Structures begin differing at: # $got->[0] = '1006' # $expected->[0] = '1005' # Looks like you failed 1 test of 6. This may be a fix, as we don't specify an order by clause in get_items_that_can_fill: - is_deeply( [ map { $_->itemnumber } $items->as_list ], + is_deeply( [ sort map { $_->itemnumber } $items->as_list ], Created attachment 133039 [details] [review] Bug 30432: Unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 133040 [details] [review] Bug 30432: Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 133041 [details] [review] Bug 30432: Fix random failure Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.05 I get a bunch of errors from the QA tool after applying these to 21.05. Please rebase for backport: FAIL t/db_dependent/Koha/Holds.t FAIL valid Use of bare << to mean <<"" is deprecated Use of bare << to mean <<"" is deprecated Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$itype_2" requires explicit package name (did you forget to declare "my $itype_2"?) Global symbol "$item_1" requires explicit package name (did you forget to declare "my $item_1"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$item_2" requires explicit package name (did you forget to declare "my $item_2"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$item_3" requires explicit package name (did you forget to declare "my $item_3"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$item_4" requires explicit package name (did you forget to declare "my $item_4"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$item_5" requires explicit package name (did you forget to declare "my $item_5"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_2" requires explicit package name (did you forget to declare "my $itype_2"?) Global symbol "$lost" requires explicit package name (did you forget to declare "my $lost"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$withdrawn" requires explicit package name (did you forget to declare "my $withdrawn"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$notforloan" requires explicit package name (did you forget to declare "my $notforloan"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) syntax error my " (Might be a runaway multi-line << string starting on line 419) t/db_dependent/Koha/Holds.t has too many errors. Created attachment 133877 [details] [review] Bug 30432: [21.05.x] Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 30432: Unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 30432: Fix random failure Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |