Summary: | Convert article requests tabs to Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, severine.queune, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Circulation function: | |||
Bug Depends on: | 30466 | ||
Bug Blocks: | 29226 | ||
Attachments: |
Bug 30436: Convert article requests tabs to Bootstrap
Bug 30436: Convert article requests tabs to Bootstrap Bug 30436: Convert article requests tabs to Bootstrap Bug 30436: Convert article requests tabs to Bootstrap |
Description
Owen Leonard
2022-04-01 15:24:40 UTC
Created attachment 132870 [details] [review] Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. Hi Owen ! After I applied the patch, the 'Select all' and 'Clear all' options don't work any more in the 'Pending' and 'Processing' tab. Everything else is ok. Created attachment 132928 [details] [review] Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. Created attachment 132933 [details] [review] Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Thank you Owen for the quick rebase, everything works fine now ! Hi, with the patch there's a minor style issue, spacing between the library dropdown and the tabs is too little: https://snipboard.io/8eNKCI.jpg (In reply to Tomás Cohen Arazi from comment #6) > Hi, with the patch there's a minor style issue, spacing between the library > dropdown and the tabs is too little: Fixed in Bug 30466. I've added it as a dependency. Created attachment 133479 [details] [review] Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> All works correctly using the scss generated from bug 30466 solved the (minor) visual glitch. Well done! Pushed to master for 22.05, thanks to everybody involved [U+1F984] |