| Summary: | Convert holds awaiting pickup tabs to Bootstrap | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, martin.renvoize, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 29226 | ||
| Attachments: |
Bug 30454: Convert holds awaiting pickup tabs to Bootstrap
Bug 30454: Convert holds awaiting pickup tabs to Bootstrap |
||
|
Description
Owen Leonard
2022-04-04 17:48:34 UTC
Created attachment 132956 [details] [review] Bug 30454: Convert holds awaiting pickup tabs to Bootstrap This patch updates the holds awaiting pickup page to replace jQueryUI tabs with Bootstrap tabs. A minor JavaScript change is required to work with the new HTML structure. To test you should have multiple holds for one library: Some which are waiting for less than the number of days specified in ReservesMaxPickUpDelay, some which are waiting longer. - Apply the patch and go to Circulation -> Holds awaiting pickup. - You should see two tabs: "Holds waiting" and "Holds waiting over..." - Confirm that the tabs look correct and work correctly. - Confirm that the "Cancel selected" buttons work correctly under each tab. Created attachment 133483 [details] [review] Bug 30454: Convert holds awaiting pickup tabs to Bootstrap This patch updates the holds awaiting pickup page to replace jQueryUI tabs with Bootstrap tabs. A minor JavaScript change is required to work with the new HTML structure. To test you should have multiple holds for one library: Some which are waiting for less than the number of days specified in ReservesMaxPickUpDelay, some which are waiting longer. - Apply the patch and go to Circulation -> Holds awaiting pickup. - You should see two tabs: "Holds waiting" and "Holds waiting over..." - Confirm that the tabs look correct and work correctly. - Confirm that the "Cancel selected" buttons work correctly under each tab. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Looks great and works as expected.. being bold and going straight for QA again here. QA scripts are happy. Passing QA Pushed to master for 22.05, thanks to everybody involved [U+1F984] |