| Summary: | Librarian ( manager_id ) not included in accountline when using "Payout amount" button | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Fines and fees | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bdaeuber, joonas.kylmala, lucas, sally.healey, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00,21.11, 22.05.05
|
|
| Circulation function: | |||
| Attachments: |
Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button
Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button Bug 30458: Include librarian (manager_id) in accountline when using "Payout amount" button |
||
|
Description
Kyle M Hall (khall)
2022-04-05 13:38:50 UTC
Created attachment 132976 [details] [review] Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button When using the "Payout amount" button, accountlines.manager_id is not populated. This is not the case with the "Issue payout" buttons. Test Plan: 1) Create a manual credit 2) Issue a payout using the "Payout amount" button 3) Inspect the payout accountline, note it has no manager_id 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the new payout accountline has a manager_id! When I do steps 1-3 I do see a manager_id without this patch. Here is what I am doing when I look: select manager_id from accountlines where debit_type_code = 'PAYOUT'; Am I doing something wrong? (In reply to Lucas Gass from comment #2) > When I do steps 1-3 I do see a manager_id without this patch. Here is what I > am doing when I look: > > select manager_id from accountlines where debit_type_code = 'PAYOUT'; > > > Am I doing something wrong? I wonder if this bug only exists in Koha 21.05.x, and not in master. Created attachment 137905 [details] [review] Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button When using the "Payout amount" button, accountlines.manager_id is not populated. This is not the case with the "Issue payout" buttons. Test Plan: 1) Create a manual credit 2) Issue a payout using the "Payout amount" button 3) Inspect the payout accountline, note it has no manager_id 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the new payout accountline has a manager_id! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> I can replicate on master (the manager_id shows if 'issue payout' is used on the individual line, but doesn't show if the 'payout amount' button at the bottom of the lines is used). After replicating the bug, I've tested the patch and it works - so signing off. Thanks for the patch. (In reply to Sally from comment #5) > I can replicate on master (the manager_id shows if 'issue payout' is used on > the individual line, but doesn't show if the 'payout amount' button at the > bottom of the lines is used). > > After replicating the bug, I've tested the patch and it works - so signing > off. Thanks for the patch. Thanks for testing, Sally! (in general, but for this one too) Created attachment 137949 [details] [review] Bug 30458: Include librarian (manager_id) in accountline when using "Payout amount" button When using the "Payout amount" button, accountlines.manager_id is not populated. This is not the case with the "Issue payout" buttons. Test Plan: 1) Create a manual credit 2) Issue a payout using the "Payout amount" button 3) Inspect the payout accountline, note it has no manager_id 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the new payout accountline has a manager_id! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> JK: Fix commit title Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Thanks, trivial fix, passing QA. Adjusted the commit title a bit as it was not passing the qa tool and didn't describe the change. Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.05 Thanks! Pushed to 21.11 for 21.11.12 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. |