Summary: | Pending archived suggestions appear on staff interface home page | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Acquisitions | Assignee: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Status: | Pushed to oldoldstable --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | minor | ||
Priority: | P5 - low | CC: | baptiste.wojtkowski, david, emily.lamancusa, fridolin.somers, jonathan.druart, koha, lucas, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the list of pending suggestions to remove archived suggestions with a "Pending" status. If suggestions were archived and their status was left as "Pending", they were still appearing as suggestions to manage on the staff interface and acquisitions home pages.
|
Version(s) released in: |
24.11.00,24.05.02,23.11.07,23.05.1
|
Circulation function: | |||
Attachments: |
Bug 30493: Pending archived suggestions appear on intranet home page
Bug 30493: Pending archived suggestions appear on intranet home page Bug 30493: Pending archived suggestions appear on intranet home page Bug 30493: Pending archived suggestions appear on intranet home page Bug 30493: (QA follow-up) Fix for the only_my_library case as well |
Description
Caroline Cyr La Rose
2022-04-07 17:01:00 UTC
*** Bug 27462 has been marked as a duplicate of this bug. *** Created attachment 167686 [details] [review] Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion The change for acqui-home.pl is missing here. Created attachment 167687 [details] [review] Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion Created attachment 167689 [details] [review] Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 167760 [details] [review] Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 167761 [details] [review] Bug 30493: (QA follow-up) Fix for the only_my_library case as well Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Looks good, and QA tool passes. Passing QA Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 Pushed to 23.11.x for 23.11.07 Backported to 23.05.x for 23.05.15 |