| Summary: | Value builder for UNIMARC field 183 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jérémy Breuillard <jeremy.breuillard> |
| Component: | Cataloging | Assignee: | Jérémy Breuillard <jeremy.breuillard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, jeremy.breuillard, lucas, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Medium patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement for UNIMARC field 183 adds value builders for subfields $a and $2. These are based on the official UNIMARC codes.
|
Version(s) released in: |
22.11.00
|
| Circulation function: | |||
| Bug Depends on: | 29159 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 30507: Value builder for field 183
Bug 30507: Value builder for field 183 Bug 30507: Value builder for field 183 Bug 30507: Value builder for field 183 Bug 30507: Value builder for field 183 Bug 30507: Value builder for field 183 |
||
|
Description
Jérémy Breuillard
2022-04-11 12:12:52 UTC
Created attachment 133152 [details] [review] Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 Hi Jérémy. There is no value builder shown when editing the subfield for $2 - unimarc_field_183-2.pl. Also, it looks like the patch (looking at the diff) also includes the changes for field 182. With the value builder for the $a subfield, when I select a value it also populates the $2 subfield with a value 'RDAcarrier'. David Created attachment 135121 [details] [review] Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 (In reply to David Nind from comment #2) > Hi Jérémy. > > There is no value builder shown when editing the subfield for $2 - > unimarc_field_183-2.pl. > > Also, it looks like the patch (looking at the diff) also includes the > changes for field 182. > > With the value builder for the $a subfield, when I select a value it also > populates the $2 subfield with a value 'RDAcarrier'. > > David Hi David, thank you for the comment. It should be fixed now Patch doesn't apply 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30507: Value builder for field 183 error: sha1 information is lacking or useless (cataloguing/value_builder/unimarc_field_182a.pl). error: could not build fake ancestor Patch failed at 0001 Bug 30507: Value builder for field 183 Created attachment 135195 [details] [review] Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 Created attachment 135196 [details] [review] Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 Created attachment 135198 [details] [review] Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 Signed-off-by: David Nind <david@davidnind.com> Created attachment 139476 [details] [review] Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be in 22.05.x |