| Summary: | Replace the use of jQueryUI Accordion on pending patron updates page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, lisettepalouse+koha, martin.renvoize, testopia, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 30494 | ||
| Bug Blocks: | 29224 | ||
| Attachments: |
Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page
Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page |
||
|
Description
Owen Leonard
2022-04-14 18:00:17 UTC
Created attachment 133332 [details] [review] Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page This patch updates the pending patron updates page to use Bootstrap collapse instead of jQueryUI. This patch contains whitespace changes, so view the diff with this in mind. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - If necessary, log into the OPAC and submit an update via the "Your personal details" page. Ideally do this for two or more patrons. - In the staff client, follow the "Patrons requesting modifications" link. - On the "Update patron records" page you should see the headings representing each of the patrons with pending updates. The first panel should be expanded. - Confirm that the panels expand and collapse correctly. - Follow the "Patron details" link for one of these patrons. - Click the "Review pending modifications" link on the patron detail page. - When the update page opens that patron's panel should be expanded. Created attachment 133412 [details] [review] Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page This patch updates the pending patron updates page to use Bootstrap collapse instead of jQueryUI. This patch contains whitespace changes, so view the diff with this in mind. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - If necessary, log into the OPAC and submit an update via the "Your personal details" page. Ideally do this for two or more patrons. - In the staff client, follow the "Patrons requesting modifications" link. - On the "Update patron records" page you should see the headings representing each of the patrons with pending updates. The first panel should be expanded. - Confirm that the panels expand and collapse correctly. - Follow the "Patron details" link for one of these patrons. - Click the "Review pending modifications" link on the patron detail page. - When the update page opens that patron's panel should be expanded. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Worked as expected. Lisette Created attachment 133472 [details] [review] Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page This patch updates the pending patron updates page to use Bootstrap collapse instead of jQueryUI. This patch contains whitespace changes, so view the diff with this in mind. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - If necessary, log into the OPAC and submit an update via the "Your personal details" page. Ideally do this for two or more patrons. - In the staff client, follow the "Patrons requesting modifications" link. - On the "Update patron records" page you should see the headings representing each of the patrons with pending updates. The first panel should be expanded. - Confirm that the panels expand and collapse correctly. - Follow the "Patron details" link for one of these patrons. - Click the "Review pending modifications" link on the patron detail page. - When the update page opens that patron's panel should be expanded. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |