Bug 30590

Summary: Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module
Product: Koha Reporter: Alex Buckley <alexbuckley>
Component: CirculationAssignee: wainuiwitikapark
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: dcook, gmcharlt, kyle.m.hall, mirjam.vantieghem
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 30590 Self-check in
Bug 30590 fixing sci sso
Bug 30590: Use AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module

Description Alex Buckley 2022-04-22 00:59:31 UTC
It would be useful if all patrons, regardless of whether they have the self_checkin_module sub-permission enabled, could check items in using the OPAC self check-in module.

This could be achieved by adding a syspref allowing libraries to choose if the Koha patron defined in the AutoSelfCheckID and AutoSelfCheckPassw sysprefs can log into the self check-in module. 
We want this so that it can be an option to add behaviour that mirrors the self check-out.

Currently, the patron in the AutoSelfCheckID and AutoSelfCheckPass sysprefs can only be used to log into the self check-out module.
Comment 1 wainuiwitikapark 2022-05-10 04:00:33 UTC
Created attachment 134801 [details] [review]
Bug 30590 Self-check in
Comment 2 wainuiwitikapark 2022-05-12 01:27:32 UTC
Created attachment 134909 [details] [review]
Bug 30590 fixing sci sso
Comment 3 wainuiwitikapark 2022-05-12 01:45:15 UTC
Created attachment 134910 [details] [review]
Bug 30590: Use AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module

Test plan:
1) Set values in 'AutoSelfCheckID' and 'AutoSelfCheckPass' system preferences, and enable 'AutoSelfCheckAllowed'
2) Enable 'SelfCheckinModule' system preference
3) Visit /cgi-bin/koha/sci/sci-main.pl and notice a login page loads
4) Apply patch and restart services
5) Repeat step 3 and notice a login page does not load this time
6) Enter a barcode, check an item in

Sponsored-by: Catalyst IT
Comment 4 Katrin Fischer 2022-06-06 21:07:28 UTC
Hi Wainui, should this be Needs Signoff?
Comment 5 wainuiwitikapark 2022-06-06 23:59:19 UTC
(In reply to Katrin Fischer from comment #4)
> Hi Wainui, should this be Needs Signoff?

Hi Katrin,

It is not yet ready to be signed off as we still need to write and add uni tests for the changes to C4/Auth.pm

Thanks,

Wainui
Comment 6 Katrin Fischer 2022-06-07 07:51:24 UTC
All good, thx for the reply!
Comment 7 Mirjam Vantieghem 2023-04-27 07:59:17 UTC
This bug seems to have the same aim as #Bug 22322.
Mark as duplicate?
Comment 8 Katrin Fischer 2023-05-03 22:24:05 UTC
(In reply to Mirjam Vantieghem from comment #7)
> This bug seems to have the same aim as #Bug 22322.
> Mark as duplicate?

Hi Mirjam, I agree they sound the same and as the other already has signed off patches, I'll mark this one as the duplicate for now.

*** This bug has been marked as a duplicate of bug 22322 ***