|
Description
Kyle M Hall (khall)
2022-04-25 17:39:09 UTC
Created attachment 133841 [details] [review] Bug 30612: Add accountlines method to Koha::Checkout and Koha::Old::Checkout It would be very useful to have an accountlines method on checkouts objects. In particular it would make fees related to a checkout available from the checkout objects in overdue notices. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Line.t 3) prove t/db_dependent/Koha/Checkouts.t Created attachment 134567 [details] [review] Bug 30612: Add accountlines method to Koha::Checkout and Koha::Old::Checkout It would be very useful to have an accountlines method on checkouts objects. In particular it would make fees related to a checkout available from the checkout objects in overdue notices. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Line.t 3) prove t/db_dependent/Koha/Checkouts.t Signed-off-by: David Nind <david@davidnind.com> Dont mix Koha/Schema/Result files with regular ones. Created attachment 135827 [details] [review] Bug 30612: Add accountlines method to Koha::Checkout and Koha::Old::Checkout It would be very useful to have an accountlines method on checkouts objects. In particular it would make fees related to a checkout available from the checkout objects in overdue notices. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Line.t 3) prove t/db_dependent/Koha/Checkouts.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 135828 [details] [review] Bug 30612: Update schema files [DO NOT PUSH] Created attachment 135829 [details] [review] Bug 30612: Update schema files Removed the "DO NOT PUSH", as these changes *do* need pushed! Shouldn't be named account_lines instead of accountlines? Created attachment 138461 [details] [review] Bug 30612: (QA follow-up) Rename accountlines method to account_lines Created attachment 138462 [details] [review] Bug 30612: Add accountlines method to Koha::Checkout and Koha::Old::Checkout It would be very useful to have an accountlines method on checkouts objects. In particular it would make fees related to a checkout available from the checkout objects in overdue notices. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Line.t 3) prove t/db_dependent/Koha/Checkouts.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 138463 [details] [review] Bug 30612: Update schema files Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 138464 [details] [review] Bug 30612: (QA follow-up) Rename accountlines method to account_lines Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 138465 [details] [review] Bug 30612: Rename other occurrences Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Just a note, it might be more handy to have ->debits and ->credits. But I will let devs decide later how they're gonna use this! Code will tell. Enhancement will not be backported to 22.05.x series Not sure what needs to be documented here. Closing, but feel free to reopen with details if needed. |