Bug 30613

Summary:	Hide RSS feed link when viewing private list in the OPAC
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	OPAC	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.05.00
Circulation function:
Attachments:	Bug 30613: Hide RSS feed link when viewing private list in the OPAC Bug 30613: Hide RSS feed link when viewing private list in the OPAC Bug 30613: Hide RSS feed link when viewing private list in the OPAC

Description Owen Leonard 2022-04-25 17:52:05 UTC

Koha requires that you be logged in to the OPAC in order to view a private list. This is true from the RSS view of a private list as well. We don't provide an alternative authentication method to enable access by RSS readers.

Unless and until someone develops a means to provide RSS access to private lists it is logical to hide the RSS icon when viewing a private list.

Comment 1 Owen Leonard 2022-05-05 14:10:40 UTC

Created attachment 134641 [details] [review]
Bug 30613: Hide RSS feed link when viewing private list in the OPAC

This patch wraps the List RSS icon in a check on whether the list is
public. Private lists RSS can only be accessed by a logged-in patron.

To test apply the patch and view a public list in the OPAC. You should
see an RSS link icon next to the list title.

Now log in to the OPAC and view a private list. There should be no RSS
link.

Note the QA tool warning about the aria-hidden attribute is a false
positive. The parent element has a label.

Comment 2 David Nind 2022-05-05 21:10:42 UTC

Created attachment 134664 [details] [review]
Bug 30613: Hide RSS feed link when viewing private list in the OPAC

This patch wraps the List RSS icon in a check on whether the list is
public. Private lists RSS can only be accessed by a logged-in patron.

To test apply the patch and view a public list in the OPAC. You should
see an RSS link icon next to the list title.

Now log in to the OPAC and view a private list. There should be no RSS
link.

Note the QA tool warning about the aria-hidden attribute is a false
positive. The parent element has a label.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2022-05-06 07:34:01 UTC

Working on this one :)

Comment 4 Katrin Fischer 2022-05-06 07:40:08 UTC

Created attachment 134677 [details] [review]
Bug 30613: Hide RSS feed link when viewing private list in the OPAC

This patch wraps the List RSS icon in a check on whether the list is
public. Private lists RSS can only be accessed by a logged-in patron.

To test apply the patch and view a public list in the OPAC. You should
see an RSS link icon next to the list title.

Now log in to the OPAC and view a private list. There should be no RSS
link.

Note the QA tool warning about the aria-hidden attribute is a false
positive. The parent element has a label.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 5 Fridolin Somers 2022-05-06 20:34:55 UTC

Pushed to master for 22.05, thanks to everybody involved ﷐[U+1F984]﷑