|
Description
Janusz Kaczmarek
2022-05-01 22:19:11 UTC
Created attachment 134446 [details] [review] Bug 30658: (bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for select input in Supplemental issue form. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new supplemantal issue. Test plan: 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 952$a, 952$b or 952$c). 3- From the subscription-detail page click on "Receive" 4- In the lower part--Supplemental issue--fill the suppelemant details, change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created I am tempted to make this major as it's a major issue in workflow if you can't add supplemental items. As the default framework is used removing all mandatory fields might be a workaround but not a good solution. Created attachment 136332 [details] [review] Bug 30658: (bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for select input in Supplemental issue form. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new supplemantal issue. Test plan: 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 952$a, 952$b or 952$c). 3- From the subscription-detail page click on "Receive" 4- In the lower part--Supplemental issue--fill the suppelemant details, change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> *** Bug 31007 has been marked as a duplicate of this bug. *** Created attachment 138450 [details] [review] Bug 30658: (bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for select input in Supplemental issue form. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new supplemantal issue. Test plan: 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 952$a, 952$b or 952$c). 3- From the subscription-detail page click on "Receive" 4- In the lower part--Supplemental issue--fill the suppelemant details, change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.05 thx pushed to 21.11.x for 21.11.12 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. |