Summary: | x-koha-override should use collectionFormat: csv | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30663 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.05.00
|
Circulation function: | |
Bug Depends on: | 30194 | ||
Bug Blocks: | |||
Attachments: |
Bug 30674: x-koha-override should use collectionFormat: csv
Bug 30674: x-koha-override should use collectionFormat: csv Bug 30674: x-koha-override should use collectionFormat: csv |
Description
Tomás Cohen Arazi (tcohen)
2022-05-03 18:03:49 UTC
Created attachment 134556 [details] [review] Bug 30674: x-koha-override should use collectionFormat: csv This patch makes this header parameter rely on the OpenAPI spec to validate and document the available options. Right now the only place is in POST and PUT /holds. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t \ t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 134563 [details] [review] Bug 30674: x-koha-override should use collectionFormat: csv This patch makes this header parameter rely on the OpenAPI spec to validate and document the available options. Right now the only place is in POST and PUT /holds. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t \ t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 134607 [details] [review] Bug 30674: x-koha-override should use collectionFormat: csv This patch makes this header parameter rely on the OpenAPI spec to validate and document the available options. Right now the only place is in POST and PUT /holds. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t \ t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great call.. all looks good here. Passing QA Pushed for 22.05. Thanks everyone. |