Summary: | Javascript broken on request.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.05.00
|
Circulation function: | |
Bug Depends on: | 30457 | ||
Bug Blocks: | |||
Attachments: |
Bug 30693: Javascript broken on request.pl
Bug 30693: Javascript broken on request.pl Bug 30693: Javascript broken on request.pl |
Description
Nick Clemens (kidclamp)
2022-05-05 14:13:14 UTC
Created attachment 134643 [details] [review] Bug 30693: Javascript broken on request.pl The holds page in the staff interface has some JavaScript relating to Bootstrap tabs, but the tabs are not always present on the page. This leads to a JS error after you have selected the patron for the hold. This patch adds a check for the tabs container element before executing the code. To test, apply the patch and locate a bibliographic record on which to place a hold. - On the initial holds screen should see tabs for "Patrons" and "Clubs." Both should work correctly. - Select a patron to place the hold for. - On the page where you enter hold details (pickup library, hold expiration, etc.) there should be no JavaScript error in the console. Created attachment 134644 [details] [review] Bug 30693: Javascript broken on request.pl The holds page in the staff interface has some JavaScript relating to Bootstrap tabs, but the tabs are not always present on the page. This leads to a JS error after you have selected the patron for the hold. This patch adds a check for the tabs container element before executing the code. To test, apply the patch and locate a bibliographic record on which to place a hold. - On the initial holds screen should see tabs for "Patrons" and "Clubs." Both should work correctly. - Select a patron to place the hold for. - On the page where you enter hold details (pickup library, hold expiration, etc.) there should be no JavaScript error in the console. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 134651 [details] [review] Bug 30693: Javascript broken on request.pl The holds page in the staff interface has some JavaScript relating to Bootstrap tabs, but the tabs are not always present on the page. This leads to a JS error after you have selected the patron for the hold. This patch adds a check for the tabs container element before executing the code. To test, apply the patch and locate a bibliographic record on which to place a hold. - On the initial holds screen should see tabs for "Patrons" and "Clubs." Both should work correctly. - Select a patron to place the hold for. - On the page where you enter hold details (pickup library, hold expiration, etc.) there should be no JavaScript error in the console. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Damn, annoyed I missed this during QA of 30457.. this fixes it nicely though.. PQA.. thanks for the quick followup. Pushed for 22.05, thanks to everyone involved :) |