Bug 30701

Summary: On small screens, upload tool buttons cannot be clicked
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: ToolsAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: master   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Attachments: Bug 30701: Make Upload Tool buttons work on mobile-size screen
Bug 30701: Make Upload Tool buttons work on mobile-size screen
Screenshot of upload tool to display Step 3 of the test plan
Bug 30701: Make Upload Tool buttons work on mobile-size screen

Description Aleisha Amohia 2022-05-06 03:33:52 UTC
The Upload tool can be accessed for Tools, and as a cataloguing plugin.

This was noticed when used for the plugin because it opened on a smaller window.

When the window is made smaller than 768 pixels, the 'Browse' and 'Upload' buttons in the 'Upload new file' section cannot be clicked.
Comment 1 Aleisha Amohia 2022-05-06 03:39:04 UTC
Created attachment 134670 [details] [review]
Bug 30701: Make Upload Tool buttons work on mobile-size screen

When the Upload tool is accessed on a smaller (mobile) screen (less than
768 pixels wide), the Upload and Browse buttons cannot be clicked. This
patch fixes that.

To test:
1) Go to Tools -> Upload
2) Make the screen narrower, either by opening your browser's Inspector
tool and using Responsive Design Mode, or by dragging in the edge of the
window to make it narrower.
3) Notice that when the screen becomes narrower than 768px, the sections
squash together and the padding between them is lost. Try to click on
the Browse and Upload buttons, notice you cannot.
4) Apply patch and refresh the Upload Tool
5) Ensure the screen is narrower than 768px. Confirm there is now
padding between the sections, and the buttons are clickable again.

Sponsored-by: Chartered Accountants Australia and New Zealand
Comment 2 Owen Leonard 2022-05-06 18:13:34 UTC
Could you attach a screenshot of how it looks before the patch? I'm not sure I'm seeing what you're seeing.
Comment 3 David Nind 2022-05-06 20:27:19 UTC
Created attachment 134762 [details] [review]
Bug 30701: Make Upload Tool buttons work on mobile-size screen

When the Upload tool is accessed on a smaller (mobile) screen (less than
768 pixels wide), the Upload and Browse buttons cannot be clicked. This
patch fixes that.

To test:
1) Go to Tools -> Upload
2) Make the screen narrower, either by opening your browser's Inspector
tool and using Responsive Design Mode, or by dragging in the edge of the
window to make it narrower.
3) Notice that when the screen becomes narrower than 768px, the sections
squash together and the padding between them is lost. Try to click on
the Browse and Upload buttons, notice you cannot.
4) Apply patch and refresh the Upload Tool
5) Ensure the screen is narrower than 768px. Confirm there is now
padding between the sections, and the buttons are clickable again.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Aleisha Amohia 2022-05-08 21:23:16 UTC
Created attachment 134769 [details]
Screenshot of upload tool to display Step 3 of the test plan

(In reply to Owen Leonard from comment #2)
> Could you attach a screenshot of how it looks before the patch? I'm not sure
> I'm seeing what you're seeing.

Screenshot attached. This describes Step 3 of the test plan. As you can see I've made the page smaller than 768px and the padding between the two sections is gone.
Comment 5 Katrin Fischer 2022-05-13 14:38:30 UTC
Created attachment 134975 [details] [review]
Bug 30701: Make Upload Tool buttons work on mobile-size screen

When the Upload tool is accessed on a smaller (mobile) screen (less than
768 pixels wide), the Upload and Browse buttons cannot be clicked. This
patch fixes that.

To test:
1) Go to Tools -> Upload
2) Make the screen narrower, either by opening your browser's Inspector
tool and using Responsive Design Mode, or by dragging in the edge of the
window to make it narrower.
3) Notice that when the screen becomes narrower than 768px, the sections
squash together and the padding between them is lost. Try to click on
the Browse and Upload buttons, notice you cannot.
4) Apply patch and refresh the Upload Tool
5) Ensure the screen is narrower than 768px. Confirm there is now
padding between the sections, and the buttons are clickable again.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 6 Fridolin Somers 2022-05-16 21:20:55 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄