Summary: | Markup error in detail page's component parts tab | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | arthur.suzuki, david, jonathan.druart, victor |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the display of the component parts tab on the bibliographic detail page in the staff interface. A missing </div> was causing content from later tabs to be incorrectly displayed at the end of the component parts tab.
|
Version(s) released in: |
22.05.00
|
Bug Depends on: | 30227 | ||
Bug Blocks: | |||
Attachments: |
Bug 30721: Markup error in detail page's component parts tab
Bug 30721: Markup error in detail page's component parts tab Bug 30721: Markup error in detail page's component parts tab |
Description
Owen Leonard
2022-05-09 15:18:30 UTC
Created attachment 134786 [details] [review] Bug 30721: Markup error in detail page's component parts tab This patch adds a missing </div> to the bibliographic detail page template in the section for showing component parts. Some comments are added to clarify the markup structure. To test you should have a record in your catalog with component parts. Bug 11175 provides one you can import if necessary: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 To see the error, go to the staff interface, locate the record in question and view the detail page. Under the Components tag, scroll to the bottom. You will see content from "later" tabs at the bottom, e.g. "There is no order for this bibliographic record" or "No images have been uploaded for this bibliograhpic record yet." Apply the patch and reload the page. The tabs should still look correct, and now the tab content should be correctly isolated. Created attachment 134800 [details] [review] Bug 30721: Markup error in detail page's component parts tab This patch adds a missing </div> to the bibliographic detail page template in the section for showing component parts. Some comments are added to clarify the markup structure. To test you should have a record in your catalog with component parts. Bug 11175 provides one you can import if necessary: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 To see the error, go to the staff interface, locate the record in question and view the detail page. Under the Components tag, scroll to the bottom. You will see content from "later" tabs at the bottom, e.g. "There is no order for this bibliographic record" or "No images have been uploaded for this bibliograhpic record yet." Apply the patch and reload the page. The tabs should still look correct, and now the tab content should be correctly isolated. Signed-off-by: David Nind <david@davidnind.com> Testing notes (koha-testing-docker): - Enable ShowComponentRecords (set to 'both staff interface and OPAC'). - When staging and importing the sample record, set the format under settings to MARCXML. Created attachment 134949 [details] [review] Bug 30721: Markup error in detail page's component parts tab This patch adds a missing </div> to the bibliographic detail page template in the section for showing component parts. Some comments are added to clarify the markup structure. To test you should have a record in your catalog with component parts. Bug 11175 provides one you can import if necessary: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 To see the error, go to the staff interface, locate the record in question and view the detail page. Under the Components tag, scroll to the bottom. You will see content from "later" tabs at the bottom, e.g. "There is no order for this bibliographic record" or "No images have been uploaded for this bibliograhpic record yet." Apply the patch and reload the page. The tabs should still look correct, and now the tab content should be correctly isolated. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 22.05, thanks to everybody involved 🦄 Ping RMaint :) pushed to 21.11.x for 21.11.07, thx Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |