| Summary: | BatchDeleteItem job param named wrongly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Architecture, internals, and plumbing | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 28445, 30710 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 30725: Rename BatchDeleteItem job param from record_ids to item_ids
Bug 30725: Rename BatchDeleteItem job param from record_ids to item_ids |
||
|
Description
Tomás Cohen Arazi (tcohen)
2022-05-10 14:52:09 UTC
Created attachment 135179 [details] [review] Bug 30725: Rename BatchDeleteItem job param from record_ids to item_ids It is clearly a copy and paste error, but the parameter is called 'record_ids' when it should be 'item_ids'. Test plan : Run prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Perform a batch items deletion via staff interface Then do the same with BatchUpdateItem I bet. Created attachment 135442 [details] [review] Bug 30725: Rename BatchDeleteItem job param from record_ids to item_ids It is clearly a copy and paste error, but the parameter is called 'record_ids' when it should be 'item_ids'. Test plan : Run prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Perform a batch items deletion via staff interface Signed-off-by: David Nind <david@davidnind.com> Testing notes using koha-testing-docker: - Before applying the patch, I tested Tools > Batch item deletion using these item barcodes for Intermediate Perl (http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=126): 39999000005134 39999000005110 39999000005158 39999000005097 ==> Items successfully deleted. - After applying the patch, I tested with these barcodes for Perl template toolkit (http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=255): 39999000011111 39999000011135 39999000011074 39999000011098 ==> Items successfully deleted. I was using "record" as a generic term, not related to bibliographic records. If you really want to adjust it, then you should fix BatchUpdateItem as well. (In reply to Jonathan Druart from comment #5) > I was using "record" as a generic term, not related to bibliographic records. > If you really want to adjust it, then you should fix BatchUpdateItem as well. Fair point. Even "item" can be considered as a generic term for an object in a list. It works, we should not touch it. |