Bug 30740

Created attachment 134916 [details] [review]
Bug 30740: Link to authorities 'used in' should not use equal

When showing an authority, there is a link to search biblio records it is used in.
Actually this link uses 'q=an=$auth_id', this is wrong for an URL, and other places use 'idx:value'.
It does not break search with Zebra nor Elasticsearch but it is better to use ':'

Test plan :
Check changed links return same results with and without patch

Created attachment 134938 [details] [review]
Bug 30740: Link to authorities 'used in' should not use equal

When showing an authority, there is a link to search biblio records it is used in.
Actually this link uses 'q=an=$auth_id', this is wrong for an URL, and other places use 'idx:value'.
It does not break search with Zebra nor Elasticsearch but it is better to use ':'

Test plan :
Check changed links return same results with and without patch

Signed-off-by: David Nind <david@davidnind.com>

Testing notes using koha-testing-docker.

I used the authority term "Agile software development" (authority id = 133) - this is used in two records in the sample data.

The search results were the same before and after the patch was applied.

I only tested with the Zebra search engine.

Links are changed/fixed on:
- the OPAC search results page - number of records link: changes an=133 to an:133
- the staff interface details page - "Used on X record(s)" link: changes an=133 to an:133

Details
=======

OPAC
~~~~

- Before:

  . Search results page - number of records link: http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&op=do_search&q=an=133
  
  . Authority details page - "Number of records used in: 2": http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&q=133&idx=an,phr

- After:
  . Search results page - number of records link: http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&op=do_search&q=an:133
  
  . Authority details page - "Number of records used in: 2":  http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&q=133&idx=an,phr

Staff interface
~~~~~~~~~~~~~~~

- Before:

  . Search results page - number of records link: http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&idx=an,phr&q=133
  
  . Authority details page - "Used in 2 record(s)": http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&q=an=133

- After:

  . Search results page - number of records link: http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&idx=an,phr&q=133
  
  . Authority details page - "Used in 2 record(s)": http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&q=an:133

Ahhh link is different between results and detail page :
q=133&idx=an,phr
q=an=133

I will open an other bug report for that

(In reply to Fridolin Somers from comment #4)
> Ahhh link is different between results and detail page :
> q=133&idx=an,phr
> q=an=133
> 
> I will open an other bug report for that

No need to - I did and fixed it, has been waiting for sign-off:
Bug 29048 - Incorrect search for linked authority records from authority search result list in OPAC

Created attachment 134945 [details] [review]
Bug 30740: Link to authorities 'used in' should not use equal

When showing an authority, there is a link to search biblio records it is used in.
Actually this link uses 'q=an=$auth_id', this is wrong for an URL, and other places use 'idx:value'.
It does not break search with Zebra nor Elasticsearch but it is better to use ':'

Test plan :
Check changed links return same results with and without patch

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Pushed to master for 22.05, thanks to everybody involved ﷐[U+1F984]﷑