Bug 30761

Summary:	Typo: PLease
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	arthur.suzuki, jonathan.druart, lucas
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00, 22.05.01
Circulation function:
Bug Depends on:	29925
Bug Blocks:
Attachments:	Bug 30761: Fix typos in OPAC reset password template Bug 30761: Fix typos in OPAC reset password template Bug 30761: Fix typos in OPAC reset password template

Description Katrin Fischer 2022-05-15 09:06:53 UTC

Found while translating:

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt:58

. %s You must contact the library for assistance %s %s An unknown error occurred. PLease try again or contact the library for assistance %s␠

Comment 1 Owen Leonard 2022-05-17 12:34:37 UTC

Created attachment 135069 [details] [review]
Bug 30761: Fix typos in OPAC reset password template

This patch corrects the word "PLease" to "Please." The patch also adds
some periods at the end of some alert strings to make punctuation
consistent between different alerts.

To test, an inspection of the patch is probably enough. The main fix
(the "PLease") only appears when an unknown error occurs.

Comment 2 David Nind 2022-05-17 18:12:25 UTC

Created attachment 135077 [details] [review]
Bug 30761: Fix typos in OPAC reset password template

This patch corrects the word "PLease" to "Please." The patch also adds
some periods at the end of some alert strings to make punctuation
consistent between different alerts.

To test, an inspection of the patch is probably enough. The main fix
(the "PLease") only appears when an unknown error occurs.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Jonathan Druart 2022-05-18 13:02:02 UTC

Created attachment 135107 [details] [review]
Bug 30761: Fix typos in OPAC reset password template

This patch corrects the word "PLease" to "Please." The patch also adds
some periods at the end of some alert strings to make punctuation
consistent between different alerts.

To test, an inspection of the patch is probably enough. The main fix
(the "PLease") only appears when an unknown error occurs.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 4 Tomás Cohen Arazi (tcohen) 2022-06-01 19:02:20 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 5 Lucas Gass (lukeg) 2022-06-06 16:01:14 UTC

Backported to 22.05.x for 22.05.01

Comment 6 Arthur Suzuki 2022-06-08 12:39:19 UTC

depends on enhancement 29925 not released in 21.11, won't backport.