Bug 30767

Summary:	Terminology: Do not forget that the issue has not been checked in yet.
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Bugs List <koha-bugs>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	arthur.suzuki, aude.charillon, lucas, victor
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00, 22.05.04, 21.11.11
Circulation function:
Attachments:	Bug 30767: Changes word "issue" to "item" Bug 30767: Changes word "issue" to "item" Bug 30767: Changes word "issue" to "item"

Description Katrin Fischer 2022-05-15 12:36:34 UTC

Issue should be checkout:

koha-tmpl/intranet-tmpl/prog/en/modules/tools/preview_letter.tt:14

Do not forget that the issue has not been checked in yet.

Comment 1 Katrin Fischer 2022-05-15 12:38:44 UTC

Or maybe item?

Comment 2 Koha Training Catalyst 2022-07-07 23:14:16 UTC

Created attachment 137341 [details] [review]
Bug 30767: Changes word "issue" to "item"

Please test and confirm terminology is now correct.
Was unable to test without steps to reproduce.

Sponsored-by: Catalyst IT

Comment 3 Chris Cormack 2022-07-07 23:26:55 UTC

Created attachment 137346 [details] [review]
Bug 30767: Changes word "issue" to "item"

Please test and confirm terminology is now correct.
Was unable to test without steps to reproduce.

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Works as expected, needs indpendent signoff

Comment 4 Katrin Fischer 2022-07-08 08:28:09 UTC

Created attachment 137377 [details] [review]
Bug 30767: Changes word "issue" to "item"

Please test and confirm terminology is now correct.
Was unable to test without steps to reproduce.

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 5 Katrin Fischer 2022-07-08 08:30:01 UTC

Thanks for your patch! Always happy to see these things fixed, passing QA too.

Missing test plan, because these were found during the translation process, sorry for that!

Comment 6 Tomás Cohen Arazi (tcohen) 2022-07-08 18:26:34 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 7 Lucas Gass (lukeg) 2022-08-12 16:44:37 UTC

Backported to 22.05.x for 22.05.04

Comment 8 Arthur Suzuki 2022-08-16 12:50:46 UTC

in 21.11.x for 21.11.11

Comment 9 Victor Grousset/tuxayo 2022-08-19 22:55:36 UTC

Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Comment 10 Aude Charillon 2023-07-28 09:21:06 UTC

Checked manual; no changes needed.