Summary: | Typo: pin should be PIN | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Michal Urban <michalurban177> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | lucas, michalurban177 |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.11.00, 22.05.03
|
Circulation function: | |
Attachments: |
Bug 30768: Capitalizing "pin" in 2FA setup
Bug 30768: Capitalizing "pin" in 2FA setup Bug 30768: Capitalizing "pin" in 2FA setup Bug 30768: Capitalizing "pin" in 2FA setup |
Description
Katrin Fischer
2022-05-15 12:58:15 UTC
koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt:61 Pin code: Created attachment 135788 [details] [review] Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comp> To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Tw> 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. IF this is ready for signoff (the bug doesn't say so): The changes to the template and test look great, but the .po files shouldn't be changed in the patch. They will get updated when translations are updated. Created attachment 135822 [details] [review] Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comprehension To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Two-Factor 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. (In reply to Owen Leonard from comment #3) > IF this is ready for signoff (the bug doesn't say so): The changes to the > template and test look great, but the .po files shouldn't be changed in the > patch. They will get updated when translations are updated. I wasn't sure if there needed to be changes in the .po files, but thanks for clarification. The new patch reverts the changes, and only keeps the template/test changes. Created attachment 135833 [details] [review] Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comprehension To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Two-Factor 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. Signed-off-by: David Nind <david@davidnind.com> Created attachment 135850 [details] [review] Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comprehension To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Two-Factor 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Template and test changes look good, tests all still pass, QA script is happy. Welcome aboard Michal! (In reply to Lucas Gass from comment #8) > Template and test changes look good, tests all still pass, QA script is > happy. > > Welcome aboard Michal! Thanks Lucas! :) Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.03 |