Bug 30770

Summary:	Terminology: Lost reserve
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Tosca Waerea <toscawaerea>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	arthur.suzuki, caroline.cyr-la-rose, victor
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00, 22.05.04, 21.11.11
Circulation function:
Bug Depends on:	30764
Bug Blocks:
Attachments:	Bug 30770: Fixed terminology 'reserve' -> 'hold' Bug 30770: Fixed terminology 'reserve' -> 'hold' Bug 30770: Fixed terminology 'reserve' -> 'hold' Bug 30770: Fixed terminology 'reserve' -> 'hold' Bug 30770: (QA follow-up) Fixing the last occurrence of reserve in returns.tt

Description Katrin Fischer 2022-05-15 13:08:01 UTC

reserve should be hold here:

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt:135

Lost reserve

Comment 1 Koha Training Catalyst 2022-07-07 23:16:08 UTC

Created attachment 137342 [details] [review]
Bug 30770: Fixed terminology 'reserve' -> 'hold'

Test plan:
1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
2. Note that it says 'Lost reserve'
3. Apply patch
4. Note that it says 'Lost hold'

Sponsored by: Catalyst IT

Comment 2 Koha Training Catalyst 2022-07-07 23:17:34 UTC

Created attachment 137343 [details] [review]
Bug 30770: Fixed terminology 'reserve' -> 'hold'

Test plan:
1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
2. Note that it says 'Lost reserve'
3. Apply patch
4. Note that it says 'Lost hold'

Note:
I was not able to trigger the behaviour to see the text in question

Sponsored-by: Catalyst IT

Comment 3 Chris Cormack 2022-07-07 23:32:44 UTC

Created attachment 137347 [details] [review]
Bug 30770: Fixed terminology 'reserve' -> 'hold'

Test plan:
1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
2. Note that it says 'Lost reserve'
3. Apply patch
4. Note that it says 'Lost hold'

Note:
I was not able to trigger the behaviour to see the text in question

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Patch looks fine, needs independent signoff

Comment 4 Katrin Fischer 2022-07-08 08:24:59 UTC

Created attachment 137376 [details] [review]
Bug 30770: Fixed terminology 'reserve' -> 'hold'

Test plan:
1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
2. Note that it says 'Lost reserve'
3. Apply patch
4. Note that it says 'Lost hold'

Note:
I was not able to trigger the behaviour to see the text in question

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 5 Katrin Fischer 2022-07-08 08:25:35 UTC

Thanks for your patch, Tosca! Going straight to PQA.

Comment 6 Katrin Fischer 2022-07-08 08:32:39 UTC

Created attachment 137378 [details] [review]
Bug 30770: (QA follow-up) Fixing the last occurrence of reserve in returns.tt

Reserve -> Hold

Comment 7 Tomás Cohen Arazi (tcohen) 2022-07-08 18:15:28 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 8 Arthur Suzuki 2022-08-16 12:33:31 UTC

found in 22.05.x for 22.05.04.
backporting in 21.11.x for 21.11.11

Comment 9 Victor Grousset/tuxayo 2022-08-19 22:49:01 UTC

Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Comment 10 Caroline Cyr La Rose 2023-05-09 17:02:34 UTC

The string 'lost reserve' is not in the manual.