| Summary: | Do not need to remove items from import biblios marc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, jonathan.druart, lucas, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00,22.05.06,21.11.12
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 38279 | ||
| Attachments: |
Bug 30779: Do not update import marc after importing items
Bug 30779: Do not update import marc after importing items Bug 30779: Remove _update_import_record_marc and update tests Bug 30779: Remove _update_import_record_marc and update tests Bug 30779: Do not update import marc after importing items Bug 30779: Remove _update_import_record_marc and update tests |
||
|
Description
Nick Clemens (kidclamp)
2022-05-16 19:55:59 UTC
Created attachment 135051 [details] [review] Bug 30779: Do not update import marc after importing items We are stripping the marc item tags at import - we save them when not importing items, but strip when importing items I think we can save on writes by leaving them in the record. This also allows comparison to what was staged versus items created To test: 1 - Stage a marc record with items, but do not look for items 2 - Confirm the item tags remain in staged marc 3 - Import the record 4 - Confirm items are nto in imported marc record 5 - Stage the record again, but look for items 6 - Confirm the item tags are stipped from imported record 7 - Import and confirm imported record has no item tags 8 - Apply patch and repeat 1-5 9 - Confirm item tags remain in record 10 - Import and confirm item tags not in imported marc Created attachment 138475 [details] [review] Bug 30779: Do not update import marc after importing items We are stripping the marc item tags at import - we save them when not importing items, but strip when importing items I think we can save on writes by leaving them in the record. This also allows comparison to what was staged versus items created To test: 1 - Stage a marc record with items, but do not look for items 2 - Confirm the item tags remain in staged marc 3 - Import the record 4 - Confirm items are nto in imported marc record 5 - Stage the record again, but look for items 6 - Confirm the item tags are stipped from imported record 7 - Import and confirm imported record has no item tags 8 - Apply patch and repeat 1-5 9 - Confirm item tags remain in record 10 - Import and confirm item tags not in imported marc Signed-off-by: Andrew <andrewfh@dubcolib.org> * space vs time? How do you decide which one is best? :D * _update_import_record_marc is no longer used * Missing tests. Created attachment 139275 [details] [review] Bug 30779: Remove _update_import_record_marc and update tests This patch removes the now unused: _update_import_record_marc Additionally, as items are already present in import biblio we no longer need to embed them, so that parameter is removed In all cases, we were embedding, so we don't need a way to get without Tests updated (In reply to Jonathan Druart from comment #3) > * space vs time? How do you decide which one is best? :D Storage can be expanded, and space recovered. Time is not a renewable resource > * _update_import_record_marc is no longer used removed > * Missing tests. tests updated Created attachment 139285 [details] [review] Bug 30779: Remove _update_import_record_marc and update tests This patch removes the now unused: _update_import_record_marc Additionally, as items are already present in import biblio we no longer need to embed them, so that parameter is removed and the option removed from the sub and pod and everywhere it was used In all cases, we were embedding, so we don't need a way to get without Tests updated Created attachment 139287 [details] [review] Bug 30779: Do not update import marc after importing items We are stripping the marc item tags at import - we save them when not importing items, but strip when importing items I think we can save on writes by leaving them in the record. This also allows comparison to what was staged versus items created To test: 1 - Stage a marc record with items, but do not look for items 2 - Confirm the item tags remain in staged marc 3 - Import the record 4 - Confirm items are nto in imported marc record 5 - Stage the record again, but look for items 6 - Confirm the item tags are stipped from imported record 7 - Import and confirm imported record has no item tags 8 - Apply patch and repeat 1-5 9 - Confirm item tags remain in record 10 - Import and confirm item tags not in imported marc Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 139288 [details] [review] Bug 30779: Remove _update_import_record_marc and update tests This patch removes the now unused: _update_import_record_marc Additionally, as items are already present in import biblio we no longer need to embed them, so that parameter is removed and the option removed from the sub and pod and everywhere it was used In all cases, we were embedding, so we don't need a way to get without Tests updated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.06 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. Thanks! Pushed to 21.11 for 21.11.12 |