Summary: | Columns Home library and Checked out from in wrong order on table settings for account_fines table | ||
---|---|---|---|
Product: | Koha | Reporter: | Emmi Takkinen <emmi.takkinen> |
Component: | Staff interface | Assignee: | Emmi Takkinen <emmi.takkinen> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, sally.healey |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.03
|
|
Circulation function: | |||
Attachments: |
Bug 30798: Change column order on account-fines table column settings
Bug 30798: Change column order on account-fines table column settings Bug 30798: Change column order on account-fines table column settings |
Description
Emmi Takkinen
2022-05-18 09:04:02 UTC
Created attachment 135094 [details] [review] Bug 30798: Change column order on account-fines table column settings Columns Home library and Checked out from are in wrong order on table settings. Because of this hiding Home library actually hides Checkout out from column and vice versa. This patch changes order of these columns on columns_settings.yml To test: 1) Navigate to columns settings page and modify account-fines tables column. => Note that if you hide column checked_out_from, column home_library is hidden on patrons account page. 2) Apply patch and restart plack etc. => Column checked_out_from should now be hidden. Sponsored-by: Koha-Suomi Oy Created attachment 135109 [details] [review] Bug 30798: Change column order on account-fines table column settings Columns Home library and Checked out from are in wrong order on table settings. Because of this hiding Home library actually hides Checkout out from column and vice versa. This patch changes order of these columns on columns_settings.yml To test: 1) Navigate to columns settings page and modify account-fines tables column. => Note that if you hide column checked_out_from, column home_library is hidden on patrons account page. 2) Apply patch and restart plack etc. => Column checked_out_from should now be hidden. Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed off, works as described. I tested the following combinations: - both columns hidden - both columns visible - column 1 visible, column 2 hidden - column 1 hidden, column 1 visible I tested via Table Settings and via the Columns setting on boraccount.pl, and it reacts correctly with each modification. Created attachment 135971 [details] [review] Bug 30798: Change column order on account-fines table column settings Columns Home library and Checked out from are in wrong order on table settings. Because of this hiding Home library actually hides Checkout out from column and vice versa. This patch changes order of these columns on columns_settings.yml To test: 1) Navigate to columns settings page and modify account-fines tables column. => Note that if you hide column checked_out_from, column home_library is hidden on patrons account page. 2) Apply patch and restart plack etc. => Column checked_out_from should now be hidden. Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.03 |