| Summary: | "Libraries" link on OPAC should be hideable by system preference | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | Needs documenting --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, lucas, m.de.rooy, phil, roman.dolny |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36742 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement adds a system preference which allows the Koha administrator to hide the "Libraries" link which appears under the main search bar in the OPAC. The preference is enabled by default because that reflects the previous default behavior.
|
Version(s) released in: |
24.11.00
|
| Circulation function: | |||
| Bug Depends on: | 13388 | ||
| Bug Blocks: | 36742 | ||
| Attachments: |
Bug 30873: Add system preference to hide libraries link in the OPAC
Bug 30873: Add system preference to hide libraries link in the OPAC Bug 30873: Add system preference to hide libraries link in the OPAC Bug 30873: Add system preference to hide libraries link in the OPAC Bug 30873: Add system preference to hide libraries link in the OPAC |
||
|
Description
David Cook
2022-06-01 02:30:44 UTC
I agree. It was a nightmare when we upgraded to that version, all my clients were unhappy with the change for some reason (and very vocal about it). They have gotten used to it since, fortunately, although if this goes through, I'm sure a lot of them will disable it. Adding this type of thing should definitely come with a syspref. Would it suffice to hide the "Libraries" link in the OPAC when there are no libraries set to "public?" We should definitely do that, but does it fulfill the need described in this bug? (In reply to Owen Leonard from comment #2) > Would it suffice to hide the "Libraries" link in the OPAC when there are no > libraries set to "public?" We should definitely do that, but does it fulfill > the need described in this bug? No, for this one we just need to hide it completely. Most of my libraries don't want the link there at all. Like David said, I think there should be an on/off switch, plus if it's on hide if there are no "public" libraries. Found Bug 36742 which addresses the presence of the link if there are no public libraries Created attachment 168210 [details] [review] Bug 30873: Add system preference to hide libraries link in the OPAC Some users would prefer that the libraries link not appear in the menu of links under the OPAC's main search bar. This patch adds a preference to do so. The preference defaults to "On" since "On" is the current default behavior. To test, apply the patch and run the database update prcoess. - In the OPAC, confirm that by default the "Libraries" link appears. - In the staff interface, go to Administration -> System preferences -> OPACShowLibraries - Set the preference to "Don't show" - Return to the OPAC and confirm that the "Libraries" link isn't there. - Try to navigate directly to /cgi-bin/koha/opac-library.pl. You should be redirected to a 404 page. Sponsored-by: Athens County Public Libraries Minor nit: the comment in opac-library.pl says "OpacTopissue" rather than "OPACShowLibraries". But at least we know it's copied from working code! (In reply to Phil Ringnalda from comment #7) > Minor nit: the comment in opac-library.pl says "OpacTopissue" rather than > "OPACShowLibraries". But at least we know it's copied from working code! Good spot. If you're going to sign this one off, feel free to add a patch to fix that. I'd be happy to QA both together. Created attachment 168231 [details] [review] Bug 30873: Add system preference to hide libraries link in the OPAC Some users would prefer that the libraries link not appear in the menu of links under the OPAC's main search bar. This patch adds a preference to do so. The preference defaults to "On" since "On" is the current default behavior. To test, apply the patch and run the database update prcoess. - In the OPAC, confirm that by default the "Libraries" link appears. - In the staff interface, go to Administration -> System preferences -> OPACShowLibraries - Set the preference to "Don't show" - Return to the OPAC and confirm that the "Libraries" link isn't there. - Try to navigate directly to /cgi-bin/koha/opac-library.pl. You should be redirected to a 404 page. Sponsored-by: Athens County Public Libraries Created attachment 168233 [details] [review] Bug 30873: Add system preference to hide libraries link in the OPAC Some users would prefer that the libraries link not appear in the menu of links under the OPAC's main search bar. This patch adds a preference to do so. The preference defaults to "On" since "On" is the current default behavior. To test, apply the patch and run the database update prcoess. - In the OPAC, confirm that by default the "Libraries" link appears. - In the staff interface, go to Administration -> System preferences -> OPACShowLibraries - Set the preference to "Don't show" - Return to the OPAC and confirm that the "Libraries" link isn't there. - Try to navigate directly to /cgi-bin/koha/opac-library.pl. You should be redirected to a 404 page. Sponsored-by: Athens County Public Libraries Created attachment 168250 [details] [review] Bug 30873: Add system preference to hide libraries link in the OPAC Some users would prefer that the libraries link not appear in the menu of links under the OPAC's main search bar. This patch adds a preference to do so. The preference defaults to "On" since "On" is the current default behavior. To test, apply the patch and run the database update prcoess. - In the OPAC, confirm that by default the "Libraries" link appears. - In the staff interface, go to Administration -> System preferences -> OPACShowLibraries - Set the preference to "Don't show" - Return to the OPAC and confirm that the "Libraries" link isn't there. - Try to navigate directly to /cgi-bin/koha/opac-library.pl. You should be redirected to a 404 page. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 168351 [details] [review] Bug 30873: Add system preference to hide libraries link in the OPAC Some users would prefer that the libraries link not appear in the menu of links under the OPAC's main search bar. This patch adds a preference to do so. The preference defaults to "On" since "On" is the current default behavior. To test, apply the patch and run the database update prcoess. - In the OPAC, confirm that by default the "Libraries" link appears. - In the staff interface, go to Administration -> System preferences -> OPACShowLibraries - Set the preference to "Don't show" - Return to the OPAC and confirm that the "Libraries" link isn't there. - Try to navigate directly to /cgi-bin/koha/opac-library.pl. You should be redirected to a 404 page. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I've seen this a few times recently, so noting here: Please include a success line (say or say_success) in your database updates after the SQL has been run. "options" is missing here from the parameter list of the new pref:
('OPACShowHoldQueueDetails','none','none|priority|holds|holds_priority','Show holds details in OPAC','Choice'),
+('OPACShowLibraries', '1', 'If enabled, a link is shown in the OPAC pointing to a page with library information', '', 'YesNo'),
('OPACShowMusicalInscripts','0','','Display musical inscripts on the OPAC record details page when available.','YesNo'),
Fixed.
Pushed for 24.11! Well done everyone, thank you! |