|
Description
Jonathan Druart
2022-06-01 08:08:39 UTC
Created attachment 135524 [details] [review] Bug 30874: Replace categoryname Created attachment 135525 [details] [review] Bug 30874: Reduce number of category fetches Created attachment 135526 [details] [review] Bug 30874: 2 more - need more investigation Created attachment 135527 [details] [review] Bug 30874: Simplify categories loop construction Fancy a code golf? Created attachment 135528 [details] [review] Bug 30874: Simplify categories loop construction Created attachment 135529 [details] [review] Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? Fancy a code golf? Looked at the first patches and it's obviously an improvement. I can't offer a lot of 'golfing', but maybe we could still get some improvements out of these patches? ping? It would be a shame to lose this enhancement. Created attachment 138443 [details] [review] Bug 30874: Replace categoryname Created attachment 138444 [details] [review] Bug 30874: Reduce number of category fetches Created attachment 138445 [details] [review] Bug 30874: 2 more - need more investigation Created attachment 138446 [details] [review] Bug 30874: Simplify categories loop construction Created attachment 138447 [details] [review] Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? Test plan: Create a new patron in a given category => Form show the dropdown with the selected category Edit again => Value is kept Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee Edit the patron, change the category, and confirm that the different limitation are correctly applied. Created attachment 138545 [details] [review] Bug 30874: Replace categoryname == Test plan == 1. Apply all patches 2. Create a new patron in a given category => Form show the dropdown with the selected category 3. Edit again => Value is kept 4. Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee 5. Edit the patron, change the category, and confirm that the different limitation are correctly applied. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 138546 [details] [review] Bug 30874: Reduce number of category fetches Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 138547 [details] [review] Bug 30874: 2 more - need more investigation Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 138548 [details] [review] Bug 30874: Simplify categories loop construction Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 138549 [details] [review] Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> It works :) Added test plan to 1st patch. QAing Created attachment 138637 [details] [review] Bug 30874: Replace categoryname == Test plan == 1. Apply all patches 2. Create a new patron in a given category => Form show the dropdown with the selected category 3. Edit again => Value is kept 4. Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee 5. Edit the patron, change the category, and confirm that the different limitation are correctly applied. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 138638 [details] [review] Bug 30874: Reduce number of category fetches Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 138639 [details] [review] Bug 30874: 2 more - need more investigation Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 138640 [details] [review] Bug 30874: Simplify categories loop construction Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 138641 [details] [review] Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 22.11. Nice work everyone, thanks! Missing 22.05.x dependencies, no backport |