Description
Marie-Luce Laflamme
2022-06-07 19:13:39 UTC
It's not that is not working, it's not the same table. The "relative's checkouts" table is not part of the table settings yet. Created attachment 137218 [details] [review] Bug 30922: Make the "Relative's checkouts" table configurable by the table settings Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden A couple of comments from testing: 1. This works for the relatives' checkouts tab on the check out and details sections of the patron's page. 2. Normally, when the table settings are configurable, there is a 'Columns' button above the actual table that lets you toggle the columns on and off. I'm not seeing it for this table. For an example, check out something to the guarantor and you should see what I mean. Created attachment 137332 [details] [review] Bug 30922: Make the "Relative's checkouts" table configurable by the table settings Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden 6- Also notice the "Columns" and "Export" buttons that should work as intended Created attachment 137334 [details] [review] Bug 30922: Make the "Relative's checkouts" table configurable by the table settings Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden 6- Also notice the "Columns" and "Export" buttons that should work as intended Signed-off-by: David Nind <david@davidnind.com> I've compared in colum_settings.yaml 'issues-table' and 'relatives-issues-table'. We see that 'homebranch' is missing from relatives issues table. But it is also missing in checkouts.js so it is for another bug report. I imagine no one would like to hide the "patron" column but we can keep it configurable. Created attachment 139089 [details] [review] Bug 30922: Make the "Relative's checkouts" table configurable by the table settings Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden 6- Also notice the "Columns" and "Export" buttons that should work as intended Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Pushed to master for 22.11. Nice work everyone, thanks! Enhancment will not be backported to 22.05.x series |