Bug 30923

Summary: OAuth2 implementation is not experimental
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: REST APIAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, david, lucas, martin.renvoize, nick, tomascohen
Version: MainKeywords: Manual-updated
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/581
Text to go in the release notes:
This enhancement removes the [EXPERIMENTAL] text from the RESTOAuth2ClientCredentials system preference description. OAuth2 has been in use by third parties to securely interact with Koha since its introduction in 2018.
Version(s) released in:
22.11.00, 22.05.03
Attachments: Bug 30923: Remove EXPERIMENTAL mark on RESTOAuth2ClientCredentials
Bug 30923: Remove EXPERIMENTAL mark on RESTOAuth2ClientCredentials
Bug 30923: Remove EXPERIMENTAL mark on RESTOAuth2ClientCredentials

Description Tomás Cohen Arazi 2022-06-07 19:53:52 UTC
We added a confusing warning on the sysprefs. OAuth2 has been used by third parties to interact with Koha in a secure way since its introduction back in 2018.
Comment 1 Tomás Cohen Arazi 2022-06-07 19:58:38 UTC
Created attachment 135786 [details] [review]
Bug 30923: Remove EXPERIMENTAL mark on RESTOAuth2ClientCredentials

The feature is not experimental at all.

To test:
1. Search for the RESTOAuth2ClientCredentials syspref
=> FAIL: It says it is an experimental feature
2. Apply this patch and reload
3. Repeat 1
=> SUCCESS: No longer marked as experimental
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2022-06-07 23:41:53 UTC
Created attachment 135787 [details] [review]
Bug 30923: Remove EXPERIMENTAL mark on RESTOAuth2ClientCredentials

The feature is not experimental at all.

To test:
1. Search for the RESTOAuth2ClientCredentials syspref
=> FAIL: It says it is an experimental feature
2. Apply this patch and reload
3. Repeat 1
=> SUCCESS: No longer marked as experimental
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Nick Clemens 2022-06-08 12:10:53 UTC
Created attachment 135796 [details] [review]
Bug 30923: Remove EXPERIMENTAL mark on RESTOAuth2ClientCredentials

The feature is not experimental at all.

To test:
1. Search for the RESTOAuth2ClientCredentials syspref
=> FAIL: It says it is an experimental feature
2. Apply this patch and reload
3. Repeat 1
=> SUCCESS: No longer marked as experimental
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2022-06-08 14:28:09 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-07-12 16:39:01 UTC
Backported to 22.05.x for 22.05.03
Comment 6 Martin Renvoize 2022-09-16 13:35:05 UTC
Docs patches merged.