Bug 30973

Summary: Serials search wrong body id
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: SerialsAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.03
Circulation function:
Attachments: Bug 30973: Serials search fix body id
Bug 30973: Serials search fix body id
Bug 30973: Serials search fix body id

Description Fridolin Somers 2022-06-16 07:55:29 UTC
The serials search page serials/serials-search.pl has HTML body id :
  <body id="ser_serials-home" class="ser">
It is the same as serials home page.
Comment 1 Fridolin Somers 2022-06-16 08:00:07 UTC
Created attachment 136125 [details] [review]
Bug 30973: Serials search fix body id

The serials search page serials/serials-search.pl has HTML body id :
  <body id="ser_serials-home" class="ser">
It is the same as serials home page.

This patch replaces with id="ser_serials-search"

Test plan :
1) Go to Serials > Advanced search
2) Look at HTML code
3) Check you see <body id="ser_serials-search" class="ser">
Comment 2 Martin Renvoize (ashimema) 2022-06-16 09:55:44 UTC
Created attachment 136138 [details] [review]
Bug 30973: Serials search fix body id

The serials search page serials/serials-search.pl has HTML body id :
  <body id="ser_serials-home" class="ser">
It is the same as serials home page.

This patch replaces with id="ser_serials-search"

Test plan :
1) Go to Serials > Advanced search
2) Look at HTML code
3) Check you see <body id="ser_serials-search" class="ser">

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2022-06-16 09:56:39 UTC
Trivial improvement, no JS functions or CSS tied to the original ID.. Straight PQA from me.
Comment 4 David Nind 2022-06-16 10:13:18 UTC
Created attachment 136144 [details] [review]
Bug 30973: Serials search fix body id

The serials search page serials/serials-search.pl has HTML body id :
  <body id="ser_serials-home" class="ser">
It is the same as serials home page.

This patch replaces with id="ser_serials-search"

Test plan :
1) Go to Serials > Advanced search
2) Look at HTML code
3) Check you see <body id="ser_serials-search" class="ser">

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-06-16 12:49:13 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2022-06-20 06:27:17 UTC
Whaooo thank you all, I tough this would end in the never-fixed limbo ^
Comment 7 Lucas Gass (lukeg) 2022-07-13 20:04:44 UTC
Backported to 22.05.x for 22.05.03