| Summary: | Remove option to clear pickup location selects on multi-holds page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jason Robb <jrobb> |
| Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
| Status: | RESOLVED MOVED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Jason Robb
2022-06-22 15:08:20 UTC
After a picking at this a little bit more, it seems the custom jQuery I'm using to prefill the pickup locations is facilitating the problem. If I disable the jQuery, the page pops up an alert and won't save with an empty pickup location. The X to clear that top pickup location select doesn't appear when placing a single-title hold so it might still make sense to get rid of it on the multi-hold page to match behaviors. The x is part of the select2 pull downs, not sure if it can be removed. The larger issue was that holds could be placed without branchcodes assigned under certain circumstances. If I'm understanding correctly, bug 31086 seems to fully prevent that from happening so this may not be a problem any longer. (In reply to Jason Robb from comment #3) > The larger issue was that holds could be placed without branchcodes assigned > under certain circumstances. > > If I'm understanding correctly, bug 31086 seems to fully prevent that from > happening so this may not be a problem any longer. Marking as MOVED. |