Summary: | Obscure notice handling in overdue_notices.pl needs to be improved | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Marcel de Rooy
2022-07-01 06:37:30 UTC
ccing Nick Tomas Jonathan Lowering severity because I just now see that parse_overdues_letter does call GetPreparedLetter after all. This code really needs to be improved. Obscure stuff. This whole stuff with loops, repeat, substitute in old and new style with or without enclosing tag is such a mess ! A librarian changed a few notices, and I just had a 'diagonal glance' over them. They looked good, but didnt work finally ;) But resolving it, almost needs debugging Letters and Overdues code. No Koha advertising.. |