Bug 31122

Summary:	Terminology: Replace & with and for Notices & slips
Product:	Koha	Reporter:	David Nind <david>
Component:	Notices	Assignee:	David Nind <david>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	arthur.suzuki, lucas, victor
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This updates occurrences of 'Notices & slips' with 'Notices and slips', as per the terminology guidelines.	Version(s) released in:	22.11.00, 22.05.04, 21.11.11
Circulation function:
Attachments:	Bug 31122: Terminology - Replace occurences of 'Notices & slips' with 'Notices and slips' Bug 31122: Terminology - Replace occurences of 'Notices & slips' with 'Notices and slips'

Description David Nind 2022-07-08 11:59:10 UTC

From the terminology list, "Only use "&" when part of a proper noun or a common abbreviation, such as Baker & Taylor or R&D. Otherwise use "and". "

Update needed for the page titles, description and breadcrumbs for Tools > Patrons and circulation > Notices & slips.

To find occurrences: 
- git grep 'Notices &amp; slips' -- :^misc/translator/po
- git grep 'Notices & slips'

Comment 1 David Nind 2022-07-08 12:30:02 UTC

Created attachment 137407 [details] [review]
Bug 31122: Terminology - Replace occurences of 'Notices & slips' with 'Notices and slips'

Replace occurences of 'Notices & slips' with 'Notices and slips'
(replacing '&' and '&amp' with 'and'), as per the terminology
guidelines.

See the terminology list:
https://wiki.koha-community.org/wiki/Terminology

Test plan:
1. Find occurrences of 'Notices & slips':
   - git grep 'Notices &amp; slips' -- :^misc/translator/po
   - git grep 'Notices & slips'
2. Review places in the staff interface where 'Messages & slips' is
   displayed:
   - Tools home page
   - Tools > Notices & slips: page title and breadcrumb
   - Other breadcrumbs:
     . Tools > Notices & slips > New notice > [select any module]
     . Tools > Notices & slips > [select Edit for any notice]
     . Tools > Notices & slips > [select Delete for any notice]
3. Review other occurences:
   . The cron job description for misc/cronjobs/holds/holds_reminder.pl:
     misc/cronjobs/holds/holds_reminder.pl -man (scroll down to the
     description)
   . The TalkingTech README file:
     vi misc/cronjobs/thirdparty/TalkingTech.README
4. Apply the patch.
5. Re-run the grep queries from step 1 - no occurences are now found.
6. Review places where 'Notices & slips' was found in steps 2 and 3 -
   these should all be replaced with 'Notices and slips' and should
   read correctly.
7. Sign off!

Alernative: review the diff for the patch and check that occurences of
'&amp' and '&' are replaced with 'and' and the updated text reads
correctly.

Signed-off-by: David Nind <david@davidnind.com>

Comment 2 Katrin Fischer 2022-07-08 15:23:06 UTC

Created attachment 137430 [details] [review]
Bug 31122: Terminology - Replace occurences of 'Notices & slips' with 'Notices and slips'

Replace occurences of 'Notices & slips' with 'Notices and slips'
(replacing '&' and '&amp' with 'and'), as per the terminology
guidelines.

See the terminology list:
https://wiki.koha-community.org/wiki/Terminology

Test plan:
1. Find occurrences of 'Notices & slips':
   - git grep 'Notices &amp; slips' -- :^misc/translator/po
   - git grep 'Notices & slips'
2. Review places in the staff interface where 'Messages & slips' is
   displayed:
   - Tools home page
   - Tools > Notices & slips: page title and breadcrumb
   - Other breadcrumbs:
     . Tools > Notices & slips > New notice > [select any module]
     . Tools > Notices & slips > [select Edit for any notice]
     . Tools > Notices & slips > [select Delete for any notice]
3. Review other occurences:
   . The cron job description for misc/cronjobs/holds/holds_reminder.pl:
     misc/cronjobs/holds/holds_reminder.pl -man (scroll down to the
     description)
   . The TalkingTech README file:
     vi misc/cronjobs/thirdparty/TalkingTech.README
4. Apply the patch.
5. Re-run the grep queries from step 1 - no occurences are now found.
6. Review places where 'Notices & slips' was found in steps 2 and 3 -
   these should all be replaced with 'Notices and slips' and should
   read correctly.
7. Sign off!

Alernative: review the diff for the patch and check that occurences of
'&amp' and '&' are replaced with 'and' and the updated text reads
correctly.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 3 Katrin Fischer 2022-07-08 15:23:49 UTC

Thanks David :)

Comment 4 Tomás Cohen Arazi (tcohen) 2022-07-08 18:15:42 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 5 Lucas Gass (lukeg) 2022-08-12 15:59:14 UTC

Backported to 22.05.x for 22.05.04

Comment 6 Arthur Suzuki 2022-08-16 10:08:04 UTC

pushed to 21.11.x for 21.11.11

Comment 7 Victor Grousset/tuxayo 2022-08-19 22:30:04 UTC

Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.