Summary: | Add button to clear the cataloguing authority plugin form | ||
---|---|---|---|
Product: | Koha | Reporter: | Koha Training Catalyst <koha-training> |
Component: | Cataloging | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, caroline.cyr-la-rose, david, m.de.rooy, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | Small patch | Documentation contact: | Caroline Cyr La Rose |
Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/821 | Text to go in the release notes: |
This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records.
|
Version(s) released in: |
23.11.00
|
Circulation function: | |
Attachments: |
Bug 31132: Add button to clear the cataloguing auth finder form
Bug 31132: Add button to clear the cataloguing auth finder form Bug 31132: (follow-up) Reset dropdown values and style button Bug 31132: (follow-up) Reset dropdown values and style button Bug 31132: Add button to clear the cataloguing auth finder form Bug 31132: (follow-up) Reset dropdown values and style button Bug 31132: Add button to clear the cataloguing auth finder form Bug 31132: (follow-up) Reset dropdown values and style button |
Description
Koha Training Catalyst
2022-07-11 22:50:18 UTC
Created attachment 137595 [details] [review] Bug 31132: Add button to clear the cataloguing auth finder form This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records. To test: 1) Search for a bibliographic record in the staff interface 2) Edit a record 3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder plugin 4) Launch the authority finder plugin by clicking the Tag editor icon at the end of the field 5) If the fields are empty, add some text in the text fields 6) Click the 'Clear form' link at the bottom of the form 7) Confirm the text is cleared from the input fields and the form is empty Sponsored-by: Education Services Australia SCIS Created attachment 137596 [details] [review] Bug 31132: Add button to clear the cataloguing auth finder form This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records. To test: 1) Search for a bibliographic record in the staff interface 2) Edit a record 3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder plugin 4) Launch the authority finder plugin by clicking the Tag editor icon at the end of the field 5) If the fields are empty, add some text in the text fields 6) Click the 'Clear form' link at the bottom of the form 7) Confirm the text is cleared from the input fields and the form is empty Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david@davidnind.com> Created attachment 137601 [details] [review] Bug 31132: (follow-up) Reset dropdown values and style button This follow-up patch resets the dropdown values of the form alongside the text inputs. It styles the button to look like a link so it doesn't distract the user and get 'accidentally' clicked when attempting to submit. For me, the clear form works initially: 1. Authority finder launched for a tag 2. Clear form is styled as a text link 3. Click 'Clear form' ==> text form fields are cleared 4. For the 'Search main heading ($a only)' change to 'starts with' and enter perl as the term (don't press the search button) 5. Click 'Clear form' ==> form reset, including options and text entered However, for step 4, if you click search, and search results are displayed: 1. The 'Clear form' button is now styled as a button, rather than a link 2. Clicking 'Clear form' now only clears the text but not the options 3. The results from the previous search are still displayed Created attachment 138069 [details] [review] Bug 31132: (follow-up) Reset dropdown values and style button This follow-up patch resets the dropdown values of the form alongside the text inputs. It styles the button to look like a link so it doesn't distract the user and get 'accidentally' clicked when attempting to submit. Test that the button looks and behaves as expected after submitting a search. The feature itself works nicely, but I am not sure about the placement of the link as it 'breaks the rule' of the Cancel link always being next to the submit button. Looking at the Z39.50 search pop-up, the clear form links is placed inside the form. Maybe we should do the same here. Created attachment 150696 [details] [review] Bug 31132: Add button to clear the cataloguing auth finder form This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records. To test: 1) Search for a bibliographic record in the staff interface 2) Edit a record 3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder plugin 4) Launch the authority finder plugin by clicking the Tag editor icon at the end of the field 5) If the fields are empty, add some text in the text fields 6) Click the 'Clear form' link at the bottom of the form 7) Confirm the text is cleared from the input fields and the form is empty Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: nicolas <nicolas@inlibro.com> Created attachment 150697 [details] [review] Bug 31132: (follow-up) Reset dropdown values and style button This follow-up patch resets the dropdown values of the form alongside the text inputs. It styles the button to look like a link so it doesn't distract the user and get 'accidentally' clicked when attempting to submit. Test that the button looks and behaves as expected after submitting a search. Signed-off-by: nicolas <nicolas@inlibro.com> Created attachment 150814 [details] [review] Bug 31132: Add button to clear the cataloguing auth finder form This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records. To test: 1) Search for a bibliographic record in the staff interface 2) Edit a record 3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder plugin 4) Launch the authority finder plugin by clicking the Tag editor icon at the end of the field 5) If the fields are empty, add some text in the text fields 6) Click the 'Clear form' link at the bottom of the form 7) Confirm the text is cleared from the input fields and the form is empty Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: nicolas <nicolas@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 150815 [details] [review] Bug 31132: (follow-up) Reset dropdown values and style button This follow-up patch resets the dropdown values of the form alongside the text inputs. It styles the button to look like a link so it doesn't distract the user and get 'accidentally' clicked when attempting to submit. Test that the button looks and behaves as expected after submitting a search. Signed-off-by: nicolas <nicolas@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement, won't be backported to 23.05.x series I only updated the screenshots in the manual. |