| Summary: | We can remove 'select_column' from waiting_holds.inc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Templates | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | arthur.suzuki, david, jonathan.druart, lucas, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.05, 21.11.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 31141: Template simplification
Bug 31141: Template simplification Bug 31141: Template simplification Bug 31141: Remove 'select_column' from waiting_holds.inc |
||
|
Description
Martin Renvoize (ashimema)
2022-07-12 10:21:17 UTC
Created attachment 137617 [details] [review] Bug 31141: Template simplification In the only place we use the waiting_holds include, we were hard coded to always pass the 'select_column' variable as true. We can simply and clarify the logic by just removing this superflous variable. Test plan 1. Confirm that the waiting holds tables continue to display as expected Created attachment 137621 [details] [review] Bug 31141: Template simplification In the only place we use the waiting_holds include, we were hard coded to always pass the 'select_column' variable as true. We can simply and clarify the logic by just removing this superflous variable. Test plan 1. Confirm that the waiting holds tables continue to display as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I would suggest to improve the commit title to make it more explicit. Maybe "Remove 'select_column' from waiting_holds.inc"? Created attachment 137623 [details] [review] Bug 31141: Template simplification In the only place we use the waiting_holds include, we were hard coded to always pass the 'select_column' variable as true. We can simply and clarify the logic by just removing this superflous variable. Test plan 1. Confirm that the waiting holds tables continue to display as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Testing notes (using koha-testing-docker): 1. Place some holds for several items. 2. Check items in and confirm holds. 3. Check the list of holds awaiting pickup (Circulation > Holds > Holds awaiting pickup) 4. After applying the patch, there should be no change to the table and things should work as expected. Created attachment 137624 [details] [review] Bug 31141: Remove 'select_column' from waiting_holds.inc In the only place we use the waiting_holds include, we were hard coded to always pass the 'select_column' variable as true. We can simply and clarify the logic by just removing this superflous variable. Test plan 1. Confirm that the waiting holds tables continue to display as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Good call on the commit title, updated. Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.05 thx pushed to 21.11.x for 21.11.12 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |