| Summary: | Add some defaults for acquisitions in TestBuilder | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | arthur.suzuki, jonathan.druart, lucas, tomascohen, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.05, 21.11.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 31145: Supply defaults for vendors and funds
Bug 31145: Supply defaults for vendors and funds |
||
|
Description
Nick Clemens (kidclamp)
2022-07-12 18:52:14 UTC
Created attachment 137653 [details] [review] Bug 31145: Supply defaults for vendors and funds This is a convenience bug - when koha testing docker creates sample vendors and budgets there are small issues: 1 - The vendor website gets a random string - you can't edit the vendor without removing this 2 - The funds have random values for statistical categories, and you get empty dropdowns when choosing a fund in ordering To test: 1 - Apply patch 2 - Restart all 3 - Edit 'My vendor' 4 - note webstie is empty and you can save without changing anythign 5 - Add order to basket for my vendor 6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as text input fields 'reset_all' that is Created attachment 137654 [details] [review] Bug 31145: Supply defaults for vendors and funds This is a convenience bug - when koha testing docker creates sample vendors and budgets there are small issues: 1 - The vendor website gets a random string - you can't edit the vendor without removing this 2 - The funds have random values for statistical categories, and you get empty dropdowns when choosing a fund in ordering To test: 1 - Apply patch 2 - Restart all 3 - Edit 'My vendor' 4 - note webstie is empty and you can save without changing anythign 5 - Add order to basket for my vendor 6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as text input fields Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> QA script happy. Simple change. Straight QA. Pushed to master for 22.11. Nice work everyone, thanks! Not a big deal but this one seems weird to me. Why don't you pass the data you need instead? (In reply to Jonathan Druart from comment #6) > Not a big deal but this one seems weird to me. Why don't you pass the data > you need instead? TestBuilder is never going to put useful info here, seemed reasonable to default to NULL I don't need anything in these, but it did sometime interfere with testing or demo when fields had to be corrected Backported to 22.05.x for 22.05.05 thx pushed to 21.11.x for 21.11.12 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |