|
Description
Nick Clemens (kidclamp)
2022-07-18 17:01:05 UTC
If this is a regression it's certainly coming from bug 27526. Created attachment 137872 [details] [review] Bug 31179: Don't copy invisible subfields when duplicating items Duplicate item is intended to duplicate the visible cataloging fields of an item, however, currently it is duplicating the complete internal record of the item To recreate: 1 - find an item in Koha staff client, copy the barcode 2 - Issue this item to a patron 3 - Return to the record 4 - Edit items 5 - Click 'Actions->Duplicate' for the item in question 6 - Save the item 7 - Note in the items table above for that 'Total checkouts' 'Due date' etc. have not been copied to new item Created attachment 137875 [details] [review] Bug 31179: Don't copy invisible subfields when duplicating items Duplicate item is intended to duplicate the visible cataloging fields of an item, however, currently it is duplicating the complete internal record of the item To recreate: 1 - find an item in Koha staff client, copy the barcode 2 - Issue this item to a patron 3 - Return to the record 4 - Edit items 5 - Click 'Actions->Duplicate' for the item in question 6 - Save the item 7 - Note in the items table above for that 'Total checkouts' 'Due date' etc. have not been copied to new item Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 137876 [details] [review] Bug 31179: (QA follow-up) POD fix Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 137877 [details] [review] Bug 31179: (QA follow-up) Set field as hidden for tests We want the tests to pass in the case where field is set to visibile in Koha Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 137881 [details] [review] Bug 31179: Don't copy invisible subfields when duplicating items Duplicate item is intended to duplicate the visible cataloging fields of an item, however, currently it is duplicating the complete internal record of the item To recreate: 1 - find an item in Koha staff client, copy the barcode 2 - Issue this item to a patron 3 - Return to the record 4 - Edit items 5 - Click 'Actions->Duplicate' for the item in question 6 - Save the item 7 - Note in the items table above for that 'Total checkouts' 'Due date' etc. have not been copied to new item Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 137882 [details] [review] Bug 31179: (QA follow-up) POD fix Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 137883 [details] [review] Bug 31179: (QA follow-up) Set field as hidden for tests We want the tests to pass in the case where field is set to visibile in Koha Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! Any chance this can be backported to 21.11. We just upgraded to 21.11 and have started to notice this duplicate item behavior. +1 - backporting would be helpful! Libraries might not notice the internal duplication until after the fact, which may make cleanup difficult. *** Bug 31285 has been marked as a duplicate of this bug. *** Upping severity. Lucas, Arthur, don't forget to backport this one for the next release! Backported to 22.05.x for 22.05.04 pushed to 21.11.x for 21.11.11 Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Nothing to document, marking resolved. |