Bug 31204

Summary:	Edit dropdown on results.tt should indicate it is record modification
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Tools	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	CLOSED FIXED	QA Contact:	Joonas Kylmälä <joonas.kylmala>
Severity:	trivial
Priority:	P5 - low	CC:	joonas.kylmala, sally.healey, victor
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00,21.11, 22.05.05
Circulation function:
Attachments:	Bug 31204: Clearly indicate edit buttons are for record modification Bug 31204: Clearly indicate edit buttons are for record modification Bug 31204: Clearly indicate edit buttons are for record modification

Description Lucas Gass (lukeg) 2022-07-20 16:52:11 UTC

On results.tt there is an option to select records and then, from the toolbar, select edit and choose either 'Batch edit' or 'Batch delete'.

Some librarians have found this confusing, thinking it would lead them to 'Batch Item Modification' when instead it leads to 'Batch record modification'.

We could make it less confusing by clearly indicating this function takes the user to record modification, not item modification.

Comment 1 Lucas Gass (lukeg) 2022-07-20 16:58:19 UTC

Created attachment 137943 [details] [review]
Bug 31204: Clearly indicate edit buttons are for record modification

To test:
1. Apply patch
2. Do a search and select some records
3. On the toolbar (#selection_ops) open the Edit dropdown.
4. The labels should read 'Batch edit records' and 'Batch delete records'.

Note: To see both you must have batchmod and batchdelete permission.

Comment 2 Biblibre Sandboxes 2022-07-21 08:00:25 UTC

Created attachment 137955 [details] [review]
Bug 31204: Clearly indicate edit buttons are for record modification

To test:
1. Apply patch
2. Do a search and select some records
3. On the toolbar (#selection_ops) open the Edit dropdown.
4. The labels should read 'Batch edit records' and 'Batch delete records'.

Note: To see both you must have batchmod and batchdelete permission.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Comment 3 Sally 2022-07-21 08:01:02 UTC

Nice clear change - works as described, signing off.  Thanks for the patch.

Comment 4 Joonas Kylmälä 2022-07-21 16:11:55 UTC

Created attachment 137987 [details] [review]
Bug 31204: Clearly indicate edit buttons are for record modification

To test:
1. Apply patch
2. Do a search and select some records
3. On the toolbar (#selection_ops) open the Edit dropdown.
4. The labels should read 'Batch edit records' and 'Batch delete records'.

Note: To see both you must have batchmod and batchdelete permission.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>

Comment 5 Tomás Cohen Arazi (tcohen) 2022-07-22 17:52:54 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 6 Lucas Gass (lukeg) 2022-09-02 17:41:19 UTC

Backported to 22.05.x for 22.05.05

Comment 7 Arthur Suzuki 2022-09-14 12:59:29 UTC

Thanks!

Pushed to 21.11 for 21.11.12

Comment 8 Victor Grousset/tuxayo 2022-09-20 16:35:29 UTC

Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.