Summary: | OPACSuggestionAutoFill must be 1 or 0 | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | arthur.suzuki, cjf, lucas, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.06
|
|
Circulation function: | |||
Bug Depends on: | 14242 | ||
Bug Blocks: | |||
Attachments: |
Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere
Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere |
Description
Jonathan Druart
2022-08-01 13:19:52 UTC
The pref must be 0 or 1 in DB. We need to adjust the pref file, sysprefs.sql and update the existing value We shouldn't adjust the controllers. Created attachment 138476 [details] [review] Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere The YAML preference definition defines it as a string ('yes' or 'no' the possible values). And the opac-suggestions.tt template has one occurence of the variable being compared to a string. This patch does: - fix the template - fixes opac.pref for 0|1 - adds an atomicupdate that takes care of moving 'yes' and 'no' to their respective boolean values. To test: 1. Change the syspref value to enable/disable 2. Check on the DB that the value is wrong: $ koha-mysql kohadev > SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill'; => FAIL: It is either 'yes' or 'no' depending on what you choose. 3. Apply this patch 4. Run: $ updatedatabase 5. Repeat 2 => SUCCESS: Values are now 0 or 1 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 138488 [details] [review] Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere The YAML preference definition defines it as a string ('yes' or 'no' the possible values). And the opac-suggestions.tt template has one occurence of the variable being compared to a string. This patch does: - fix the template - fixes opac.pref for 0|1 - adds an atomicupdate that takes care of moving 'yes' and 'no' to their respective boolean values. To test: 1. Change the syspref value to enable/disable 2. Check on the DB that the value is wrong: $ koha-mysql kohadev > SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill'; => FAIL: It is either 'yes' or 'no' depending on what you choose. 3. Apply this patch 4. Run: $ updatedatabase 5. Repeat 2 => SUCCESS: Values are now 0 or 1 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 138492 [details] [review] Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere The YAML preference definition defines it as a string ('yes' or 'no' the possible values). And the opac-suggestions.tt template has one occurence of the variable being compared to a string. This patch does: - fix the template - fixes opac.pref for 0|1 - adds an atomicupdate that takes care of moving 'yes' and 'no' to their respective boolean values. To test: 1. Change the syspref value to enable/disable 2. Check on the DB that the value is wrong: $ koha-mysql kohadev > SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill'; => FAIL: It is either 'yes' or 'no' depending on what you choose. 3. Apply this patch 4. Run: $ updatedatabase 5. Repeat 2 => SUCCESS: Values are now 0 or 1 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.06 |