| Summary: | Report results are limited to 999,999 no matter the actual number of results | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Reports | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, jonathan.druart, lucas, martin.renvoize, rachael.laritz, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00,22.05.06,21.11.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 31276: Report results are limited to 999,999 no matter the actual number of results
Bug 31276: Report results are limited to 999,999 no matter the actual number of results Bug 31276: Report results are limited to 999,999 no matter the actual number of results |
||
|
Description
Kyle M Hall (khall)
2022-08-01 14:34:14 UTC
Created attachment 138477 [details] [review] Bug 31276: Report results are limited to 999,999 no matter the actual number of results In Koha, any report that uses C4::Reports::Guided will be limited to 999,999 rows. This is causing problems for larger libraries where some reports may have over a million results. Test Plan: 1) Create a report "SELECT * FROM borrowers" and run it, note the number of results 2) Apply this patch 3) Add the line `<report_results_limit>3</report_results_limit>` within the <config> block of your koha-conf.xml 4) Restart all the things! 5) Run the report, download the results as a CSV 6) Note your CSV only has 4 lines, the header and 3 patrons Please don't forget to set Assignee! There is no signed-off-by patch here. Created attachment 138915 [details] [review] Bug 31276: Report results are limited to 999,999 no matter the actual number of results In Koha, any report that uses C4::Reports::Guided will be limited to 999,999 rows. This is causing problems for larger libraries where some reports may have over a million results. Test Plan: 1) Create a report "SELECT * FROM borrowers" and run it, note the number of results 2) Apply this patch 3) Add the line `<report_results_limit>3</report_results_limit>` within the <config> block of your koha-conf.xml 4) Restart all the things! 5) Run the report, download the results as a CSV 6) Note your CSV only has 4 lines, the header and 3 patrons Signed-off-by: Rachael Laritz <rachael.laritz@inlibro.com> Created attachment 139052 [details] [review] Bug 31276: Report results are limited to 999,999 no matter the actual number of results In Koha, any report that uses C4::Reports::Guided will be limited to 999,999 rows. This is causing problems for larger libraries where some reports may have over a million results. Test Plan: 1) Create a report "SELECT * FROM borrowers" and run it, note the number of results 2) Apply this patch 3) Add the line `<report_results_limit>3</report_results_limit>` within the <config> block of your koha-conf.xml 4) Restart all the things! 5) Run the report, download the results as a CSV 6) Note your CSV only has 4 lines, the header and 3 patrons Signed-off-by: Rachael Laritz <rachael.laritz@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial change, passing QA Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.06 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. Thanks! Pushed to 21.11 for 21.11.12 |