| Summary: | already_reserved never used in opac/opac-reserve.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | nick, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
22.11.00
|
Circulation function: | |
| Bug Depends on: | |||
| Bug Blocks: | 31314 | ||
| Attachments: |
Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl
Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl |
||
Created attachment 138834 [details] [review] Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) Created attachment 138920 [details] [review] Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial, passing QA For the record:
$ git grep already_reserved | grep -v translator
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: [% IF ( bibitemloo.already_reserved ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: [% END # / IF bibitemloo.already_reserved %]
opac/opac-reserve.pl: $biblioLoopIter{already_reserved} = $biblioData->{already_reserved};
opac/opac-reserve.pl: if ($biblioLoopIter{already_reserved}) {
Pushed to master for 22.11. Nice work everyone, thanks! (In reply to Tomás Cohen Arazi from comment #4) > For the record: > > $ git grep already_reserved | grep -v translator > > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: > [% IF ( bibitemloo.already_reserved ) %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: > [% END # / IF bibitemloo.already_reserved %] > opac/opac-reserve.pl: $biblioLoopIter{already_reserved} = > $biblioData->{already_reserved}; > opac/opac-reserve.pl: if ($biblioLoopIter{already_reserved}) { Yes, the commit message could have been a bit more verbose. The flag was set to $itemLoopIter, which was never used. biblioLoopIter does use it. |
my $policy_holdallowed = !$itemLoopIter->{already_reserved}; This "already_reserved" is never used.