Description
Jonathan Druart
2022-08-08 14:22:53 UTC
Created attachment 138823 [details] [review] Bug 31314: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with opac-reserve Test plan: List items on the modified view and confirm that all the info is displayed correctly Created attachment 138882 [details] [review] Bug 31314: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with opac-reserve Test plan: List items on the modified view and confirm that all the info is displayed correctly Created attachment 138916 [details] [review] Bug 31314: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with opac-reserve Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Plan to come back, but removing QA contact to not block! Created attachment 139066 [details] [review] Bug 31314: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with opac-reserve Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 139067 [details] [review] Bug 31314: (QA follow-up) Search Koha::Items not $biblio->items To get the host items we need to search all items, not those limited to the same biblionumber To test: 1 - Enable EasyAnalytics 2 - Attach an item to a record 3 - Confirm it is listed in the items list on opac reserve Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 139068 [details] [review] Bug 31314: (QA follow-up) Prefetch and make routines use result objects This reduces lookups for the related items that we now fetch in the templates Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Passing QA, we probably want Jonathan's nod on the follow-ups or a review by RM before push Pushed to master for 22.11. Nice work everyone, thanks! |