| Summary: | Remove GetItemsInfo from serials/routing-preview | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 31306 | ||
| Bug Blocks: | 31330, 27272 | ||
| Attachments: |
Bug 31318: Remove GetItemsInfo from serials/routing-preview
Bug 31318: Remove GetItemsInfo from serials/routing-preview Bug 31318: Remove GetItemsInfo from serials/routing-preview |
||
|
Description
Jonathan Druart
2022-08-08 14:23:06 UTC
Created attachment 138828 [details] [review] Bug 31318: Remove GetItemsInfo from serials/routing-preview Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with serials/routing-preview Test plan: List items on the modified view and confirm that all the info is displayed correctly Created attachment 138901 [details] [review] Bug 31318: Remove GetItemsInfo from serials/routing-preview Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with serials/routing-preview Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> This code is actually broken, see bug 2894 and friends. I don't think we should block this patch because if this long standing bug. Created attachment 138976 [details] [review] Bug 31318: Remove GetItemsInfo from serials/routing-preview Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with serials/routing-preview Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! |